fix deprecation and possible faulty construction of pandas tables #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjdoris
reviewed
Sep 14, 2022
cjdoris
reviewed
Sep 14, 2022
| @@ -102,6 +102,6 @@ function _columns(df, columnnames, columntypes) | |||
| # output a table | |||
| # TODO: realising columns to vectors could be done lazily with a different table type | |||
| schema = Tables.Schema(colnames, coltypes) | |||
| coldict = Dict(k=>v for (k,v) in zip(colnames, columns)) | |||
| coldict = Tables.OrderedDict(k=>v for (k,v) in zip(colnames, columns)) | |||
There was a problem hiding this comment.
Looks good thanks. It unfortunately uses the non-API Tables.OrderedDict, but then we're already using the non-API constructor for Tables.DictColumnTable so 🤷♂️
There was a problem hiding this comment.
Yeah, it's not great but I figured it would be easier on everyone... it's not really an ideal API on the Tables end.
There was a problem hiding this comment.
I'll think about a PR to Tables to give some of its table types public constructors.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR pandas tables were being constructed from
Tables.DictColumnTableusing an unordered dict for the columns. This was leading to deprecation warnings as seen here but more importantly, it could result in the creation of table objects which would have content inconsistent with their schema. I'm actually a bit unsure why this was not breaking far more spectacularly (update: it's because the methods provided byDictColumnTablemake the ordering of the dict largely unnecessary, but it would still break if anything ever iterated over the columns in the dict.)I used the
OrderedDictconstructor from withinTablesfor this so as not to have to addOrderedCollectionsas a dependency.