`OrderedDict` deprecation in `DictColumnTable`

[ExpandingMan]

I'm getting the following deprecation warning from OrderedCollections, apparently due to DictColumnTable trying to make a deprecated conversion

┌ Warning: Conversion to OrderedDict is deprecated for unordered associative containers (in this case, Dict{Symbol, PyArray{T, 1, true, true, PythonCall.UnsafePyObject} where T}). Use an ordered or sorted associative type, such as SortedDict and OrderedDict.

[bkamins]

This is a quite bad deprecation. What is then a recommended way to convert a Dict to OrderedDict?

[ExpandingMan]

Hm, maybe I was running this on an older version of OrderedCollections because I'm doing OrderedDict(::Dict) and I'm not getting the warning... I'm confused.

[ExpandingMan]

Yeah, I'm really confused, I only seem to be getting this when using PythonCall for some table conversions from Python. I don't understand how that package causes this warning but just converting directly doesnt...

[bkamins]

Maybe open an issue in DataStructures.jl and someone will know?

[ExpandingMan]

Oh wait, I found it... you are just not supposed to call convert, using the constructor is fine... so, for example:

◖◗ convert(OrderedDict{Int,Int}, Dict(1=>2))
┌ Warning: Conversion to OrderedDict is deprecated for unordered associative containers (in this case, Dict{Int64, Int64}). Use an ordered or sorted associative type, such as SortedDict and OrderedDict.
│   caller = top-level scope at REPL[2]:1
└ @ Core REPL[2]:1
OrderedDict{Int64, Int64} with 1 entry:
  1 => 2

◖◗ OrderedDict(Dict(1=>2))
OrderedDict{Int64, Int64} with 1 entry:
  1 => 2

I don't see convert in dictcolumntable so it must be an implicit conversion in an assignment but I'm not sure where.

[ExpandingMan]

While arguably Tables.jl should provide more constructors for DictColumnTable, it turns out the above was not really a Tables.jl issue because the package that was calling the warning was calling DictColumnTable directly and that package was what was improperly converting a Dict, see this PR. I suppose this is a bit of a "Julia has no private constructors" issue.

Anyway, nothing to be done here, so closing.