-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix scriptdir/bindir #9
Conversation
|
||
Conda.add("jupyter=4.0.0") | ||
@test v"4.0.0"==run(`$(joinpath(Conda.SCRIPTDIR, "jypyter")) kernelspec --version`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The old equivalent to this would be @test v"4.0.0"==run(
$(joinpath(Conda.scriptsdir(), "jypyter")) kernelspec --version)
which would fail because the script do not work.
|
||
Conda.add("jupyter=1.0.0") | ||
@test v"4.0.0" == convert(VersionNumber, chomp(readall(`$(joinpath(Conda.SCRIPTDIR, "jupyter")) kernelspec --version`))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The old equivalent to this was @test v"4.0.0" == convert(VersionNumber, chomp(readall(
$(joinpath(Conda.scriptsdir("jupyter"), "jupyter")) kernelspec --version)))
which would fail because the script did not work.
…The scripts within the pkgs cannot be used because they cannot find the python interpreter.
|
||
Conda.add("jupyter=1.0.0") | ||
@test v"4.0.0" == convert(VersionNumber, chomp(readall(`$(joinpath(Conda.SCRIPTDIR, "jupyter-kernelspec")) --version`))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The old equivalent to this was @test v"4.0.0" == convert(VersionNumber, chomp(readall(
$(joinpath(Conda.scriptsdir("jupyter"), "jupyter-kernelspec")) --version)))
which would fail because the script did not work.
Thank you for that, it is nice of you ! Can you just update the documentation, and squash your commits ? |
I have change the documentation to match. Are there any further changes to the documentation you see necerssary? |
No, sorry, I was tired ... Thank you again ! |
When I tried to update JuliaLang/IJulia.jl#357 to use the bindir and scriptdir function I found that the function pointed to the wrong scripts/bins. The scripts within the pkgs cannot be used because they cannot find the python interpreter. On Linux the Ipython script in
deps/usr/bin
works as intended and it looks like:the equivalent script in
deps/usr/bin/pkgs/ipython-3.1.0-py34_0/bin
do not work because it cannot find the python interpreter referenced in the first line.The case is the same on windows where executables inside
deps\usr\pkgs
do not work, while the equivalent executable indeps\usr\Scripts
work. Therefore this PR update's to use the globalbin
directory on Linux andScripts
directory windows indeps/usr/
. Asbindir/scriptdir
is not package dependent anymore I have made them constants and capitalized.