[WIP] Use Conda.jl if Ipython/jupyter is not found #357
Conversation
| @@ -2,4 +2,4 @@ julia 0.3 | |||
| Nettle | |||
| JSON 0.2 | |||
| ZMQ 0.1 | |||
| Compat 0.7 | |||
| Compat 0.7 | |||
|
I have updated the pull to a working condition. It do only work on master of Conda.jl. @Luthaf maybe you could tag a new version? While getting this to work I bumped into jupyter/notebook#448. I have added a workaround for the issue. |
dhoegh
changed the title
| @@ -3,3 +3,4 @@ Nettle | |||
| JSON 0.2 | |||
| ZMQ 0.1 | |||
| Compat 0.7 | |||
| Conda | |||
There was a problem hiding this comment.
(please end the file with a newline)
|
dhoegh
force-pushed
the
Use_Conda
branch
2 times, most recently
from
7ba87a9
to
52c00d6
Compare
|
I have pushed a new version that fixes the workaround when IPython3 is used and the new lines. |
| # Remove the commit that added this when https://github.com/jupyter/notebook/issues/448 is closed | ||
| run(`$jupyter-kernelspec install --replace --user $juliakspec`) | ||
| else | ||
| run(`$jupyter-kernelspec install --replace --user $juliakspec`) |
There was a problem hiding this comment.
Is this supposed to be $jupyter kernelspec?
jupyter/ipython is found.
jupyter/notebook#448 is closed and released.
| @@ -78,4 +96,16 @@ copy_config("logo-32x32.png", juliakspec) | |||
| copy_config("logo-64x64.png", juliakspec) | |||
|
|
|||
| eprintln("Installing julia kernelspec $spec_name") | |||
| run(`$jupyter kernelspec install --replace --user $juliakspec`) | |||
| if basename(jupyter) == "jupyter" | |||
| # Remove the commit that added this when https://github.com/jupyter/notebook/issues/448 is closed | |||
There was a problem hiding this comment.
Just say # Just use "$jupyter kernelspec" when jupyter/notebook#448 is resolved and widely available. I don't think I want to bother with a separate commit for this.
|
Looking good. Can you squash the commits? |
|
Oh nevermind, I guess we can leave it as two commits. |
[WIP] Use Conda.jl if Ipython/jupyter is not found
|
Yup, updating the README now. |
|
👏 🎆 |
This is the first working version of an integrated IPython setup on all platforms.
JUPYTERenvironment variableconst jupyter = "..."in a IJulia/deps/deps.jl file that is generated duringPkg.build, and is included from IJulia.jl