[adwaita_icon_theme] fix windows installation issues for v3. #8003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why? Can we see what's the issue? |
|
When I run the old I'm not sure why, or if this will cause issues with Details
|
|
It's mainly a bunch of pngs that are different? If they're dynamically generated probably they aren't bit-by-bit reproducible, and so not a big deal? Did you try to visually compare them? |
|
Some of the icons seem weird in the version at https://github.com/JuliaBinaryWrappers/adwaita_icon_theme_jll.jl/releases/tag/adwaita_icon_theme-v3.33.92%2B4 Local rebuild: |
|
Because a few of the ".png" files in v3.33.92+4 seem broken, I'm rebuilding now instead of just copying the previous artifact. |
|
|
|
I also tested |
|
Thanks! |
grasph
pushed a commit
to Moelf/Yggdrasil
that referenced
this pull request
Jul 1, 2024
…ckaging#8003) * [adwaita_icon_theme] fix windows installation issues for v3. * [adwaita_icon_theme] rebuild
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply the fix in #7930 for the old version of
adwaita_icon_theme_jll.jlrequired byGtk.jlThe difference in the tree sha is because the new version is missing the "logs" directory and a few icons are fixed in the "share" directory.
I assume after this PR is merged I should make a PR to undo the changes to go back to the new version?