This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Allow Gtk.jl to be installed on Windows on Julia 1.10. #697
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows
Gtk.jl
to be installed on Windows on Julia 1.10.The version of
adwaita_icon_theme_jll
required byGtk.jl
contains symlinks. This prevents it from being installed on Windows in Julia 1.10 due to stricter artifact integrity checking. Ref: JuliaLang/Pkg.jl#3643 and JuliaPackaging/Yggdrasil#7860This got fixed for the most recent version of
adwaita_icon_theme_jll
in JuliaPackaging/Yggdrasil#7930However, it seems like
adwaita_icon_theme_jll
version 43 is not compatible withGtk.jl
Ref: #696This PR replaces the
adwaita_icon_theme_jll
dependency with a regular artifact. For Linux and BSD this doesn't change anything, for Windows, a special version ofadwaita_icon_theme
is installed where the symlinks have been replaced with copies. This Windows version has the same tree hash as the version installed in Julia 1.9 on Windows if symlinks cannot be made.You can check the
git-tree-sha1
values in theArtifact.toml
in this PRand compare to the reported expected and calculated hashes in JuliaPackaging/Yggdrasil#7860
Also, currently, I am storing the Windows artifact at
https://github.com/medyan-dev/SmallZarrGroups.jl/releases/download/v0.6.6/copy_symlinks_adwaita_icon_theme.v3.33.92.any.tar.gz
but there may be a better place for it.CC @jwahlstrand @revolutionflourlake772