Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Allow Gtk.jl to be installed on Windows on Julia 1.10. #697

Closed
wants to merge 3 commits into from
Closed

Allow Gtk.jl to be installed on Windows on Julia 1.10. #697

wants to merge 3 commits into from

Conversation

nhz2
Copy link

@nhz2 nhz2 commented Jan 12, 2024

This PR allows Gtk.jl to be installed on Windows on Julia 1.10.

The version of adwaita_icon_theme_jll required by Gtk.jl contains symlinks. This prevents it from being installed on Windows in Julia 1.10 due to stricter artifact integrity checking. Ref: JuliaLang/Pkg.jl#3643 and JuliaPackaging/Yggdrasil#7860

This got fixed for the most recent version of adwaita_icon_theme_jll in JuliaPackaging/Yggdrasil#7930

However, it seems like adwaita_icon_theme_jll version 43 is not compatible with Gtk.jl Ref: #696

This PR replaces the adwaita_icon_theme_jll dependency with a regular artifact. For Linux and BSD this doesn't change anything, for Windows, a special version of adwaita_icon_theme is installed where the symlinks have been replaced with copies. This Windows version has the same tree hash as the version installed in Julia 1.9 on Windows if symlinks cannot be made.

You can check the git-tree-sha1 values in the Artifact.toml in this PR
and compare to the reported expected and calculated hashes in JuliaPackaging/Yggdrasil#7860

Calculated git-tree-sha1: 043d0732f572e66059278f5964e3752f018a5cdf
git-tree-sha1 = "043d0732f572e66059278f5964e3752f018a5cdf"

Also, currently, I am storing the Windows artifact at https://github.com/medyan-dev/SmallZarrGroups.jl/releases/download/v0.6.6/copy_symlinks_adwaita_icon_theme.v3.33.92.any.tar.gz but there may be a better place for it.

CC @jwahlstrand @revolutionflourlake772

@coveralls
Copy link

coveralls commented Jan 12, 2024

Pull Request Test Coverage Report for Build 7534881522

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.1%) to 69.086%

Totals Coverage Status
Change from base Build 3788169661: 2.1%
Covered Lines: 1875
Relevant Lines: 2714

💛 - Coveralls

@nhz2 nhz2 changed the title Test PR to check if adwaita_icon_theme_jll can be replaced with an Artifact Replace adwaita_icon_theme_jll with an Artifact Jan 15, 2024
@nhz2 nhz2 changed the title Replace adwaita_icon_theme_jll with an Artifact Allow Gtk.jl to be installed on Windows on Julia 1.10. Jan 16, 2024
@nhz2 nhz2 marked this pull request as ready for review January 16, 2024 00:01
@nhz2
Copy link
Author

nhz2 commented Jan 26, 2024

Closing because I think JuliaPackaging/Yggdrasil#8003 is a better fix.

@nhz2 nhz2 closed this Jan 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants