fix on 1.3 and add Project file

.travis.yml

@@ -4,15 +4,10 @@ os:
   - linux
   - osx
 julia:
-  - 0.7
   - 1.0
+  - 1.2
   - nightly
 notifications:
   email: false
-
-script:
-  - if [[ -a .git/shallow ]]; then git fetch --unshallow; fi
-  - julia --color=yes -e 'using InteractiveUtils; versioninfo(); import Pkg; Pkg.clone(pwd()); Pkg.build("GenericSVD")'
-  - julia --color=yes --check-bounds=yes -e 'import Pkg; Pkg.test("GenericSVD"; coverage=true)'
 after_success:
-  - julia -e 'import Pkg; cd(Pkg.dir("GenericSVD")); Pkg.add("Coverage"); using Coverage; Coveralls.submit(process_folder()); Codecov.submit(process_folder())'
+  - julia --project -e 'import Pkg; Pkg.add("Coverage"); using Coverage; Coveralls.submit(process_folder()); Codecov.submit(process_folder())'

Project.toml

@@ -0,0 +1,18 @@
+name = "GenericSVD"
+uuid = "01680d73-4ee2-5a08-a1aa-533608c188bb"
+version = "0.2.2"
+
+[deps]
+LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
+
+[compat]
+julia = "1.0"
+
+[extras]
+LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
+Quaternions = "94ee1d12-ae83-5a48-8b1c-48b8ff168ae0"
+Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"
+Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
+
+[targets]
+test = ["LinearAlgebra", "Test", "Random", "Quaternions"]

appveyor.yml

@@ -1,7 +1,7 @@
 environment:
   matrix:
-  - julia_version: 0.7
   - julia_version: 1.0
+  - julia_version: 1.2
   - julia_version: latest
 
 platform:

src/GenericSVD.jl

@@ -7,9 +7,12 @@ import LinearAlgebra: SVD, svd!
 include("utils.jl")
 include("bidiagonalize.jl")
 
-function svd!(X::AbstractMatrix; full::Bool=false, thin::Union{Bool,Nothing} = nothing)
+function svd!(X::AbstractMatrix; full::Bool=false, thin::Union{Bool,Nothing} = nothing, alg=nothing)
+    if alg != nothing
+        @warn "keyword `alg` ignored in generic svd!"
+    end
     if thin != nothing
-        @warn "obsolete keyword thin in generic svd!"
+        @warn "obsolete keyword `thin` in generic svd!"
         thinx = thin
     else
         thinx = !full