Skip to content
This repository was archived by the owner on Apr 26, 2021. It is now read-only.

fix on 1.3 and add Project file #19

Merged
merged 3 commits into from
Sep 20, 2019
Merged

fix on 1.3 and add Project file #19

merged 3 commits into from
Sep 20, 2019

Conversation

KristofferC
Copy link
Contributor

@KristofferC KristofferC commented Sep 20, 2019

Fixes #18

@KristofferC
Copy link
Contributor Author

KristofferC commented Sep 20, 2019

Alternatively, we tag this with just a patch version to not force dependees to tag new versions to be compatible? This is non-breaking but it means we cannot backport things to 0.7 compatible versions. But that should be fine... Opinions @andreasnoack?

@andreasnoack
Copy link
Member

The intention here is clear to patch so I'd be fine with making this a patch release to try minimizing the trouble for users.

@KristofferC
Copy link
Contributor Author

Agreed.

@KristofferC KristofferC merged commit 07156af into master Sep 20, 2019
@fredrikekre fredrikekre deleted the kc/project branch September 20, 2019 08:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

broken in julia 1.3 by added alg keyword argument
2 participants