Skip to content

Fix for Julia v1.5 #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 30, 2020
Merged

Fix for Julia v1.5 #25

merged 3 commits into from
Jul 30, 2020

Conversation

dlfivefifty
Copy link
Member

This will fix #21 once JuliaLang/julia#35929 is backported

@codecov
Copy link

codecov bot commented Jul 30, 2020

Codecov Report

Merging #25 into master will increase coverage by 4.81%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
+ Coverage   70.91%   75.73%   +4.81%     
==========================================
  Files           8        8              
  Lines         973     1022      +49     
==========================================
+ Hits          690      774      +84     
+ Misses        283      248      -35     
Impacted Files Coverage Δ
src/ArrayLayouts.jl 68.75% <100.00%> (-0.99%) ⬇️
src/diagonal.jl 41.66% <0.00%> (-3.79%) ⬇️
src/factorizations.jl 91.19% <0.00%> (-0.29%) ⬇️
src/triangular.jl 93.33% <0.00%> (+0.65%) ⬆️
src/ldiv.jl 71.05% <0.00%> (+2.63%) ⬆️
src/muladd.jl 60.23% <0.00%> (+3.85%) ⬆️
src/lmul.jl 82.35% <0.00%> (+5.88%) ⬆️
src/memorylayout.jl 76.10% <0.00%> (+14.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3e5959...09b66d1. Read the comment docs.

@dlfivefifty dlfivefifty merged commit 66fef87 into master Jul 30, 2020
@dlfivefifty dlfivefifty deleted the dl/julia1.5 branch July 30, 2020 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test errors on 1.5 due to ambiguities caused by type piracy
1 participant