Skip to content

Test errors on 1.5 due to ambiguities caused by type piracy #21

Closed
@KristofferC

Description

@KristofferC

This package and other dependencies fail on 1.5 due to ambiguities that this package introduces,

https://github.com/JuliaMatrices/ArrayLayouts.jl/blob/ba76345a24f0a6618fec80ab17193bfe7923543a/src/ArrayLayouts.jl#L83-L86

The test errors are of the form

  MethodError: unsafe_convert(::Type{Ptr{Float64}}, ::Adjoint{Float64,Array{Float64,2}}) is ambiguous. Candidates:
    unsafe_convert(::Type{Ptr{T}}, A::Adjoint{var"#s822",var"#s821"} where var"#s821"<:(StridedVecOrMat{T} where T) where var"#s822"<:Real) where T in LinearAlgebra at /opt/julia/share/julia/stdlib/v1.5/LinearAlgebra/src/adjtrans.jl:208
    unsafe_convert(::Type{Ptr{T}}, A::Adjoint{var"#s13",S} where S where var"#s13"<:Real) where T<:Real in ArrayLayouts at /home/pkgeval/.julia/packages/ArrayLayouts/S2dXf/src/ArrayLayouts.jl:83
  Possible fix, define
    unsafe_convert(::Type{Ptr{T}}, ::Adjoint{var"#s822",var"#s821"} where var"#s821"<:(StridedVecOrMat{T} where T) where var"#s822"<:Real) where T<:Real

It would be good to either remove these methods or try to get them into Base.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions