test: Automatically install Revise for revise- targets
#58559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keno
added a commit
that referenced
this pull request
May 29, 2025
This was supposed to be in #58559, but I accidentally forgot to check it in.
vtjnash
reviewed
May 29, 2025
| $(call PRINT_JULIA, $(call spawn,RELOCATEDEPOT="" $(JULIA_EXECUTABLE)) $(TEST_JULIA_OPTIONS) ./runtests.jl $(TEST_SCRIPT_OPTIONS) $@) | ||
|
|
||
| revise-relocatedepot: revise-% : | ||
| revise-relocatedepot: revise-% : dep_revise |
Member
There was a problem hiding this comment.
This doesn't appear to be a legal target?
Member
Author
There was a problem hiding this comment.
If you're talking about the dependency, you're correct, I ended up deciding it should do this on the julia side - I'll remove the typo. If you're talking about the two :, that's apparently something called a static pattern rule, which I didn't know about.
Member
There was a problem hiding this comment.
The static pattern is fine (and pre existing). It is a convenience feature for avoiding calling subst in this example
Keno
added a commit
that referenced
this pull request
May 30, 2025
This was supposed to be in #58559, but I accidentally forgot to check it in.
Keno
added a commit
that referenced
this pull request
May 30, 2025
Our docsystem has the ability to install a local working copy of documenter, complete with manifest/project and local depot to keep things isolated from user packages. I recently made all of this work out of tree, and in #58559 added the same mechanism for the installation of revise in test-revise-*. However, then I realized that the docsystem also has the ability to install a copy of Reivse. Clearly a third copy of all of this is excessive. Instead, unify all the manifests into `deps/jlutilities`, so that the same Revise project/manifest is used for both doc and test. Similarly, only use one depot at `buildroot/deps/jlutilities/depot` that both systems share.
Keno
added a commit
that referenced
this pull request
May 30, 2025
Our docsystem has the ability to install a local working copy of documenter, complete with manifest/project and local depot to keep things isolated from user packages. I recently made all of this work out of tree, and in #58559 added the same mechanism for the installation of revise in test-revise-*. However, then I realized that the docsystem also has the ability to install a copy of Reivse. Clearly a third copy of all of this is excessive. Instead, unify all the manifests into `deps/jlutilities`, so that the same Revise project/manifest is used for both doc and test. Similarly, only use one depot at `buildroot/deps/jlutilities/depot` that both systems share.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #50256, by automatically installing a private copy of
Reviseinto test/deps, similar to the mechanism for Documenter in make.jl. As in #58529, I made sure that this worked with both in-tree and out-of-tree builds.