Fix out-of-tree docs build #58529
Merged
Fix out-of-tree docs build #58529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `doc` build had only limited out-of-tree support. In particular, it was relying on creating in-tree `stdlib` symbolic links (due to a missing feature in Documenter), as well as pointing external stdlibs to the in-tree references rather than the out-of-tree ones. Fix this by building up the reading of the buildroot and splitting `@__DIR__` references appropriately, depending on whether they refer to the source or the output. Fixes #53039.
Keno
added a commit
that referenced
this pull request
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
docbuild had only limited out-of-tree support. In particular, it was relying on creating in-treestdlibsymbolic links (due to a missing feature in Documenter), as well as pointing external stdlibs to the in-tree references rather than the out-of-tree ones. Fix this by building up the reading of the buildroot and splitting@__DIR__references appropriately, depending on whether they refer to the source or the output. Fixes #53039.