-
-
Couldn't load subscription status.
- Fork 5.7k
Revert "replace unsafe_convert methods with safe cconvert ones" #51860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
It looks like this is an effect_system / caching issue. Somewhere along the way we compile or run a copy of |
|
Looks like there are two interconnected issues with how effects are hooked up that lead to this fatal result:
|
When inference decided it was not necessary to cache the object, it also skipped all of the work required to make the code valid, which typeinf_ext depends upon. This resulted in caching invalid data, causing effects tests to break unpredictably. This change ensures that we always update the InferenceState with the final result, so that typeinf_ext can get the correct results out of it for internal codegen use. Fixes one of the issues uncovered in #51860
When inference decided it was not necessary to cache the object, it also skipped all of the work required to make the code valid, which typeinf_ext depends upon. This resulted in caching invalid data, causing effects tests to break unpredictably. This change ensures that we always update the InferenceState with the final result, so that typeinf_ext can get the correct results out of it for internal codegen use. Fixes one of the issues uncovered in #51860
When inference decided it was not necessary to cache the object, it also skipped all of the work required to make the code valid, which typeinf_ext depends upon. This resulted in caching invalid data, causing effects tests to break unpredictably. This change ensures that we always update the InferenceState with the final result, so that typeinf_ext can get the correct results out of it for internal codegen use. Fixes one of the issues uncovered in #51860
When inference decided it was not necessary to cache the object, it also skipped all of the work required to make the code valid, which typeinf_ext depends upon. This resulted in caching invalid data, causing effects tests to break unpredictably. This change ensures that we always update the InferenceState with the final result (when `must_be_codeinf` is true), so that typeinf_ext can get the correct results out of it for internal codegen use. Previously we were disregarding that flag in some cases. Fixes one of the issues uncovered in #51860
Reverts #51764. CI is failing on master after that PR.