[REPL] Fix shell completion error on unreadable symlink #51851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test failures seem unrelated. |
|
Strange that pretty much all CI failed. I updated the branch to get a fresh run on top of latest master which should hopefully clear that up. |
|
It seems to me that EDIT: Ah, yes, I will rebase this once #51860 is figured out. |
In macOS there is a file, `/usr/sbin/weakpass_edit` that is a symlink to a directory that is only readable by `root`. Our REPL shell completion attempts to call `isfile()` when entering the shell mode and pressing `w`, throwing an ugly error into the REPL. This PR fixes the root cause (skipping files that fail the `isfile()` condition) and adds a test that synthesizes an analogous condition.
staticfloat
force-pushed
the
sf/fix_path_completion_error
branch
from
13ab7f4 to
b37f0b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In macOS there is a file,
/usr/sbin/weakpass_editthat is a symlink to a directory that is only readable byroot. Our REPL shell completion attempts to callisfile()when entering the shell mode and pressingw, throwing an ugly error into the REPL.This PR fixes the root cause (skipping files that fail the
isfile()condition) and adds a test that synthesizes an analogous condition.