update newpages pointer after actually sweeping pages #50387
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#50357 modified the sweeping code so that all objects past the
p->newpages
pointer were inserted into the freelist.I believe this means that we should reset
p->newpages
after sweeping, otherwise the code introduced in #50357 becomes a no-op sincegc_sweep_pool_page
will always observep->newpages == NULL
.