Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileWatching.Pidfile: on Windows, we must rename a file before we can delete it #44984

Merged
merged 3 commits into from
Apr 20, 2022
Merged

FileWatching.Pidfile: on Windows, we must rename a file before we can delete it #44984

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5e78486
`FileWatching.Pidfile`: on Windows, we must rename a file before we c…
DilumAluthge Apr 15, 2022
628e4f2
Change another occurence of `rm(...)` to `tryrmopenfile(...)`
DilumAluthge Apr 15, 2022
27cf687
Change the return value of `tryrmopenfile` to return the exception in…
DilumAluthge Apr 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions stdlib/FileWatching/src/pidfile.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ mutable struct LockMonitor
lock = new(at, fd, update)
finalizer(close, lock)
catch ex
rm(at)
tryrmopenfile(at)
close(fd)
rethrow(ex)
end
Expand Down Expand Up @@ -307,7 +307,7 @@ function Base.close(lock::LockMonitor)
if pathstat !== nothing && samefile(stat(lock.fd), pathstat)
# try not to delete someone else's lock
try
vtjnash marked this conversation as resolved.
Show resolved Hide resolved
rm(path)
tryrmopenfile(path)
removed = true
catch ex
ex isa IOError || rethrow()
Expand Down