FileWatching.Pidfile: on Windows, we must rename a file before we can delete it
#44984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DilumAluthge
added
the
filesystem
|
See JuliaLang/Pkg.jl#3057 (comment) and JuliaLang/Pkg.jl#3057 (comment) for context. |
|
@vtjnash I noticed that there is one other occurence of julia/stdlib/FileWatching/src/pidfile.jl Line 68 in 151a81f Should we also replace that use of |
|
Yes, anytime we delete an open file it is best to use the helper |
DilumAluthge
force-pushed
the
dpa/pidfile-rm-on-windows
branch
from
69124d9
to
a5a7e07
Compare
DilumAluthge
force-pushed
the
dpa/pidfile-rm-on-windows
branch
from
a5a7e07
to
628e4f2
Compare
vtjnash
reviewed
Apr 15, 2022
…stead of `false`
vtjnash
pushed a commit
to vtjnash/Pidfile.jl
that referenced
this pull request
Apr 20, 2022
Convert several occurrences of `rm` to `tryrmopenfile`. Refs: JuliaLang/julia#44984
vtjnash
added a commit
to vtjnash/Pidfile.jl
that referenced
this pull request
Apr 20, 2022
Convert several occurrences of `rm` to `tryrmopenfile`. Refs: JuliaLang/julia#44984 Co-authored-by: Dilum Aluthge <dilum@aluthge.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.