Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

completely initialize SystemError #44192

Merged
merged 1 commit into from
Feb 15, 2022
Merged

completely initialize SystemError #44192

merged 1 commit into from
Feb 15, 2022

Conversation

sjkelly
Copy link
Contributor

@sjkelly sjkelly commented Feb 15, 2022

before:

julia> throw(SystemError("fail"))
ERROR: 
Stacktrace:
 [1] top-level scope
   @ REPL[6]:1
SYSTEM (REPL): showing an error caused an error
ERROR: UndefRefError: access to undefined reference

after:

julia> throw(SystemError("fail"))
ERROR: SystemError: fail: Success
Stacktrace:
 [1] top-level scope
   @ REPL[1]:1

@oscardssmith oscardssmith added backport 1.6 Change should be backported to release-1.6 backport 1.7 bugfix This change fixes an existing bug merge me PR is reviewed. Merge when all tests are passing labels Feb 15, 2022
@oscardssmith oscardssmith removed the bugfix This change fixes an existing bug label Feb 15, 2022
@oscardssmith oscardssmith added the bugfix This change fixes an existing bug label Feb 15, 2022
@oscardssmith oscardssmith merged commit 2db86f2 into JuliaLang:master Feb 15, 2022
antoine-levitt pushed a commit to antoine-levitt/julia that referenced this pull request Feb 17, 2022
@sjkelly @antoine-levitt
completely initialize SystemError (JuliaLang#44192)
4d44b33
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Feb 19, 2022
KristofferC pushed a commit that referenced this pull request Feb 19, 2022
@sjkelly @KristofferC
completely initialize SystemError (#44192)
fc75979 
(cherry picked from commit 2db86f2)
@KristofferC KristofferC mentioned this pull request Feb 19, 2022
Merged
50 tasks
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
@sjkelly @LilithHafner
completely initialize SystemError (JuliaLang#44192)
ed738a9
KristofferC pushed a commit that referenced this pull request Feb 23, 2022
@sjkelly @KristofferC
completely initialize SystemError (#44192)
72cf83d 
(cherry picked from commit 2db86f2)
@KristofferC KristofferC mentioned this pull request Feb 23, 2022
Merged
40 tasks
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
@sjkelly @LilithHafner
completely initialize SystemError (JuliaLang#44192)
4446c34
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label May 16, 2022
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
@sjkelly @staticfloat
completely initialize SystemError (#44192)
581a81f 
(cherry picked from commit 2db86f2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vchuravy vchuravy vchuravy approved these changes

@vtjnash vtjnash vtjnash approved these changes

@oscardssmith oscardssmith oscardssmith approved these changes

Assignees
No one assigned
Labels
bugfix This change fixes an existing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sjkelly @vchuravy @vtjnash @oscardssmith @KristofferC @DilumAluthge