release-1.6: Backports for 1.6.6 #43735

KristofferC · 2022-01-10T09:40:55Z

Backported PRs:

Need manual backport:

Contains multiple commits, manual intervention needed:

Non-merged PRs with backport label:

Not checking could lead to a segfault on closed TCPSockets in getpeername Fixes #40993 (cherry picked from commit 28e30a3)

* Look for package name in `[extras]` When Preferences.jl set's a preferences in a non-top-level package, it adds that package to the `[extras]` entries in the project path. Package loading should have used thhose entries to map the module uuid to the key name in the Preferences.toml Fixes JuliaPackaging/Preferences.jl#24 Co-authored-by: Elliot Saba <staticfloat@gmail.com> (cherry picked from commit 8197c41)

The last entry sentinel for Win64 SEH is `~0L` not NULL. Apparently this doesn't cause issues on windows proper, but does crash wine. Arguably if Windows doesn't have issues then we should just fix this in wine, but since we control the source and nobody else ever seems to have run into this, let's just fix it and save the good Wine folks some headache. Fixes #43569. (cherry picked from commit 722f9d4)

Constructing the Regex touched in this commit can represent a significant fraction (e.g. half or better) of the runtime of the DateFormat method touched in this commit. To make this DateFormat method more efficient, let's lift that Regex construction out of that method body. (cherry picked from commit 7fb5bb8)

See comment in diff for explanation. This fixes test/stacktraces.jl on aarch64 macOS 12, and according to an OpenJDK issue where they ran into the same problem, https://git.openjdk.java.net/jdk/pull/6193, probably also x86_64 macOS 12. (cherry picked from commit 7f27dea)

To avoid the compiler potentially picking the wrong size depending on standards versions. (cherry picked from commit e8d1167)

t-bltg · 2022-01-14T12:15:23Z

@KristofferC, should #43787 be backported to 1.6.6 and also 1.7.2 ?

KristofferC · 2022-01-14T12:37:56Z

Not sure, could be argued it is a bug fix but it isn't really clear to me at least.

t-bltg · 2022-01-14T12:56:20Z

Thanks, I'd say it's a bug fix but since it's a long standing one with visual changes, maybe @JeffBezanson can make that call.

Fixes #43702 (cherry picked from commit 9d05e7b)

We could also consider adding `defalg(v::AbstractArray{<:Number}) = DEFAULT_UNSTABLE`, but it is unlikely that someone will want to do `Union` of `<:Number` and something other than `Missing` that still would support comparison. Relevant for JuliaStrings/InlineStrings.jl#21 (and other custom types that will want to add `defalg` support allowing for `Union` with `Missing`). (cherry picked from commit eb724e0)

(cherry picked from commit 9769024)

(cherry picked from commit c3235cd)

…44003 (#44004) (cherry picked from commit c10dac1)

(cherry picked from commit 546a774)

(cherry picked from commit 4c101a1)

(cherry picked from commit 2db86f2)

(cherry picked from commit c839221)

(cherry picked from commit 0c44d23)

Because we might not have synchronized the list again yet. (cherry picked from commit cac90b5)

We have 2 copies of this data, and so need to make sure we are pointing at the correct one for runtime. (cherry picked from commit 2f1f2f6)

* [CPUID] Rework how current ISA is determined * [CPUID] Add ISA entry for A64FX * [CPUID] Add ISA entry for Apple Silicon M1 * [CPUID] Simplify collection of full set of features for architecture * [CPUID] Remove AES from A64FX ISA, not all chips appear to have it (cherry picked from commit f45b6ad)

fixes #41268 (#44265) (cherry picked from commit 0b48b91)

…et (#44262) We collect the relocations (i.e. the GOT slots that is used in the code) for each target in `tgt.relocs`. Needing a relocation, however, does not imply that the function is cloned for this target within the group (It does mean that at least one target in the group has it cloned). The previous version would miss the relocation in this case. This was triggerred with the following cloning situation caller: clone_1 callee: clone_1, clone_1.clone_3 Since caller.clone_1 may call either callee.clone_1 or callee.clone_1.clone_3 a relocation for callee will be used and is required to be initialized. In addition to target 1, target 2 (and in fact target 3) within group 1 will also use caller.clone_1. However, since callee isn't cloned for target 2 the previous version wouldn't have saved this slot in the relocation array. (cherry picked from commit 76fc067)

Co-authored-by: Simeon David Schaub <schaub@mit.edu> (cherry picked from commit 2338f5d)

(cherry picked from commit 610fc20)

Fix #44227 (cherry picked from commit f731c38)

(cherry picked from commit dc61f29)

(cherry picked from commit 2c9e051)

KristofferC · 2022-03-16T13:16:35Z

@nanosoldier runbenchmarks(ALL, vs=":release-1.6")

KristofferC · 2022-03-16T13:16:52Z

@nanosoldier runtests(ALL, vs=":release-1.6")

vtjnash · 2022-03-16T20:57:15Z

https://github.com/JuliaCI/NanosoldierReports/blob/master/benchmark/by_hash/73c0033_vs_7be0dcd/report.md
seems good

nanosoldier · 2022-03-17T05:37:08Z

Your package evaluation job has completed - possible new issues were detected. A full report can be found here.

KristofferC · 2022-03-18T12:36:28Z

@nanosoldier runtests(["ADCME", "AeroAcoustics", "ArrayLayouts", "AssociativeArrays", "Batsrus", "BlockArrays", "CMAEvolutionStrategy", "Causal", "CondaPkg", "CrystallographyBase", "ExtendedDates", "GLMNet", "GaussianProcesses", "GcodeParser", "Hashpipe", "ITensorGaussianMPS", "ITensorVisualizationBase", "LatticeDiracOperators", "MIToS", "MRIgeneralizedBloch", "Mamba", "NaturalES", "NotebookToLaTeX", "NumericalAlgorithms", "OceanRobots", "PlanningDomains", "QXTns", "QXTools", "QuadEig", "RoME", "SalesForceBulkApi", "SocialSolver", "SortMark", "SpectralDistances", "StructuralIdentifiability", "SynchronicBallot", "SyntheticDatasets", "SyntheticNetworks", "TensorNetworkCodes", "TraitSimulation", "UCIData", "YAActL", "YaoQX", "ZigZagBoomerang"], vs = ":release-1.6")

nanosoldier · 2022-03-18T20:58:18Z

Your package evaluation job has completed - possible new issues were detected. A full report can be found here.

Co-authored-by: Elliot Saba <staticfloat@gmail.com> (cherry picked from commit dfcd63f)

… the external stdlib URLs (#42906) (cherry picked from commit 7eba9c1)

…t URLs (#42907) (cherry picked from commit e03ead0)

(cherry picked from commit 36304ba)

KristofferC · 2022-03-18T22:01:14Z

@nanosoldier runtests(["ArrayLayouts", "AssociativeArrays", "BlockArrays", "ExtendedDates", "GaussianProcesses", "ITensorGaussianMPS", "ITensorVisualizationBase", "Mamba", "QXTns", "QXTools", "TensorNetworkCodes", "YAActL", "YaoQX"], vs = ":release-1.6")

nanosoldier · 2022-03-18T23:31:39Z

Your package evaluation job has completed - possible new issues were detected. A full report can be found here.

(cherry picked from commit 4061e8f)

KristofferC · 2022-03-19T07:29:59Z

@nanosoldier runtests(["AssociativeArrays", "ExtendedDates", "ITensorGaussianMPS", "ITensorVisualizationBase", "QXTns", "QXTools", "TensorNetworkCodes", "YaoQX"], vs = ":release-1.6")

nanosoldier · 2022-03-19T11:45:24Z

Your package evaluation job has completed - possible new issues were detected. A full report can be found here.

KristofferC · 2022-03-19T15:12:08Z

The one remaining Pkg eval "failure" looks like a bug fix which is for some reason is tested on the previous behavior.

cljord and others added 6 commits January 10, 2022 10:38

Add check_open(sock) to _sockname (#41000)

a3bfdbe

Not checking could lead to a segfault on closed TCPSockets in getpeername Fixes #40993 (cherry picked from commit 28e30a3)

Spell out ~0L literal (#43579)

685e167

To avoid the compiler potentially picking the wrong size depending on standards versions. (cherry picked from commit e8d1167)

KristofferC added the release Release management and versioning. label Jan 10, 2022

KristofferC and others added 12 commits January 20, 2022 13:46

run a temp cleanup after the precompilation step (#43761)

7f471cb

Fixes #43702 (cherry picked from commit 9d05e7b)

[deps] Update PCRE2 URL (#43884)

ca624bb

(cherry picked from commit 9769024)

Fix typo in triangular ldiv! (#43962)

6eea8d8

(cherry picked from commit c3235cd)

Dates parsing: remove throw InexactError from tryparsenext, fixes #…

7821e64

…44003 (#44004) (cherry picked from commit c10dac1)

fix #43960, evaluation order of splat inside ref (#44024)

8a02c32

(cherry picked from commit 546a774)

fix asyncmap docs typo (#43571)

6b43499

(cherry picked from commit 4c101a1)

completely initialize SystemError (#44192)

fc75979

(cherry picked from commit 2db86f2)

fix next prompt detector in generate_precompile_statements (#44196)

c50b4a4

(cherry picked from commit c839221)

build,win: workaround for echo sometimes interpreting \\ from tr

3f0b376

(cherry picked from commit 0c44d23)

win,debug: add missing jl_refresh_dbg_module_list call

f99cf7c

Because we might not have synchronized the list again yet. (cherry picked from commit cac90b5)

debuginfo: fix offset to UnwindData on Win64

7452018

We have 2 copies of this data, and so need to make sure we are pointing at the correct one for runtime. (cherry picked from commit 2f1f2f6)

vtjnash force-pushed the backports-release-1.6 branch from f5ab4fd to 7452018 Compare February 24, 2022 20:38

giordano and others added 3 commits March 15, 2022 15:06

Fix aliasing bug in copy!(x, x) for x::AbstractSet and x::AbstractDict,

cf86fc6

fixes #41268 (#44265) (cherry picked from commit 0b48b91)

KristofferC force-pushed the backports-release-1.6 branch from 79388bf to cdfbec3 Compare March 15, 2022 15:48

Pangoraw and others added 3 commits March 16, 2022 10:35

use name in source module when importing an aliased binding (#43291)

426a4ad

Co-authored-by: Simeon David Schaub <schaub@mit.edu> (cherry picked from commit 2338f5d)

[RemoveAddrspaces] make MappedTypes non-static (#44453)

0494f96

(cherry picked from commit 610fc20)

ensure invoke kwargs work on Types (#44464)

68f0b35

Fix #44227 (cherry picked from commit f731c38)

dkarrasch and others added 2 commits March 16, 2022 10:35

Fix sparse array setindex(::Int, ::Vector) (#43678)

b4cbb96

(cherry picked from commit dc61f29)

Base.runtests: set a temporary Pkg depot path (#42358)

74d6f07

(cherry picked from commit 2c9e051)

KristofferC force-pushed the backports-release-1.6 branch from cdfbec3 to c7daef8 Compare March 16, 2022 10:05

JuliaLang deleted a comment from nanosoldier Mar 16, 2022

This comment was marked as outdated.

Sign in to view

JuliaLang deleted a comment from nanosoldier Mar 18, 2022

DilumAluthge and others added 5 commits March 18, 2022 22:55

External stdlibs: Move *_URL stdlib definitions into .version files

967fa9a

Co-authored-by: Elliot Saba <staticfloat@gmail.com> (cherry picked from commit dfcd63f)

External stdlibs: stop using the unauthenticated git:// protocol in…

4c7c053

… the external stdlib URLs (#42906) (cherry picked from commit 7eba9c1)

Remove some other uses of the unauthenticated git:// protocol in Gi…

bf6293a

…t URLs (#42907) (cherry picked from commit e03ead0)

Running make testall should run all of the tests (#42904)

356a116

(cherry picked from commit 36304ba)

Update Pkg to 1.6.6.

8c43f36

KristofferC force-pushed the backports-release-1.6 branch from 53e02a2 to 8c43f36 Compare March 18, 2022 21:59

fix #44239, regression in keyword args in getindex (#44246)

3c8241c

(cherry picked from commit 4061e8f)

KristofferC merged commit 9a16c08 into release-1.6 Mar 19, 2022

KristofferC deleted the backports-release-1.6 branch March 19, 2022 15:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

release-1.6: Backports for 1.6.6 #43735

release-1.6: Backports for 1.6.6 #43735

KristofferC commented Jan 10, 2022 •

edited

Loading

t-bltg commented Jan 14, 2022

KristofferC commented Jan 14, 2022

t-bltg commented Jan 14, 2022

KristofferC commented Mar 16, 2022

KristofferC commented Mar 16, 2022

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

vtjnash commented Mar 16, 2022

nanosoldier commented Mar 17, 2022

KristofferC commented Mar 18, 2022

nanosoldier commented Mar 18, 2022

KristofferC commented Mar 18, 2022

nanosoldier commented Mar 18, 2022

KristofferC commented Mar 19, 2022

nanosoldier commented Mar 19, 2022

KristofferC commented Mar 19, 2022

release-1.6: Backports for 1.6.6 #43735

release-1.6: Backports for 1.6.6 #43735

Conversation

KristofferC commented Jan 10, 2022 • edited Loading

t-bltg commented Jan 14, 2022

KristofferC commented Jan 14, 2022

t-bltg commented Jan 14, 2022

KristofferC commented Mar 16, 2022

KristofferC commented Mar 16, 2022

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

vtjnash commented Mar 16, 2022

nanosoldier commented Mar 17, 2022

KristofferC commented Mar 18, 2022

nanosoldier commented Mar 18, 2022

KristofferC commented Mar 18, 2022

nanosoldier commented Mar 18, 2022

KristofferC commented Mar 19, 2022

nanosoldier commented Mar 19, 2022

KristofferC commented Mar 19, 2022

KristofferC commented Jan 10, 2022 •

edited

Loading