Base.runtests: rename the --force-net option to --ci
#43168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DilumAluthge
added
testsystem
DilumAluthge
force-pushed
the
dpa/base-runtests-ci-flag
branch
from
3ee7580
to
781c88d
Compare
rfourquet
reviewed
Nov 20, 2021
Co-authored-by: Rafael Fourquet <fourquet.rafael@gmail.com>
KristofferC
pushed a commit
that referenced
this pull request
Nov 25, 2021
Co-authored-by: Rafael Fourquet <fourquet.rafael@gmail.com> Co-authored-by: Rafael Fourquet <fourquet.rafael@gmail.com> (cherry picked from commit e9430c9)
29 tasks
KristofferC
pushed a commit
that referenced
this pull request
Nov 26, 2021
Co-authored-by: Rafael Fourquet <fourquet.rafael@gmail.com> Co-authored-by: Rafael Fourquet <fourquet.rafael@gmail.com> (cherry picked from commit e9430c9)
KristofferC
pushed a commit
that referenced
this pull request
Nov 26, 2021
Co-authored-by: Rafael Fourquet <fourquet.rafael@gmail.com> Co-authored-by: Rafael Fourquet <fourquet.rafael@gmail.com> (cherry picked from commit e9430c9)
29 tasks
50 tasks
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
…#43168) Co-authored-by: Rafael Fourquet <fourquet.rafael@gmail.com> Co-authored-by: Rafael Fourquet <fourquet.rafael@gmail.com>
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
…#43168) Co-authored-by: Rafael Fourquet <fourquet.rafael@gmail.com> Co-authored-by: Rafael Fourquet <fourquet.rafael@gmail.com>
45 tasks
78 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, we have the
--force-netflag. When the--force-netflag is passed, if networking is not available, we throw an error. The motivation for the--force-netflag is CI environments, where we want CI to fail immediately if networking is not available.It occurs to me that we might want to use this flag for more things in the future, in addition to just networking.
So this PR renames the
--force-netflag to--ci.The
--force-netflag is not part of the public API, so this change is fine to make.