Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IRShow: pass idx::Int to line_info_postprinter #42137

Closed
wants to merge 1 commit into from

Conversation

aviatesk
Copy link
Member

@aviatesk aviatesk commented Sep 6, 2021

@aviatesk
Copy link
Member Author

aviatesk commented Sep 6, 2021

This is really not a bugfix, but I want to backport this change to v1.7 if possible -- it would ease the development cost for Cthulhu and similar code tools because we can cut off the compatibility efforts.

@simeonschaub
Copy link
Member

The index should already be passed inside the IOContext (see #41828), which I did to avoid any potential breakage. Can JuliaDebug/Cthulhu.jl#225 just use that?

@aviatesk
Copy link
Member Author

aviatesk commented Sep 6, 2021

yeah, it works. Thanks for your pointer !

Well, I feel it's a bit strange that we pass used as argument while wrapping idx in IOContext. We may want to pack used into IOContext as well ?

But yeah, this refactor shouldn't confuse the v1.7 release, and I think it's better to leave it for the future for now ?

@simeonschaub
Copy link
Member

Well, I feel it's a bit strange that we pass used as argument while wrapping idx in IOContext. We may want to pack used into IOContext as well ?

I agree it feels a bit inconsistent, but I am not sure changing that is really worth it.

@aviatesk aviatesk closed this Sep 6, 2021
@aviatesk aviatesk deleted the avi/postprinter branch September 6, 2021 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants