Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to show inference remarks #225

Merged
merged 1 commit into from
Sep 10, 2021
Merged

add option to show inference remarks #225

merged 1 commit into from
Sep 10, 2021

Conversation

aviatesk
Copy link
Member

@aviatesk aviatesk commented Sep 6, 2021

  • only enabled for unoptimized source
  • show remarks aside of statements, rather than callsites
  • would be mostly useful for understanding constant-prop' heuristics, but we can also see remarks emitted for e.g. recursive callsites

Would look like this:
Screen Shot 2021-09-06 at 21 01 54

@@ -118,7 +122,7 @@ function TerminalMenus.keypress(m::CthulhuMenu, key::UInt32)
elseif key == UInt32('b')
m.toggle = :bookmark
return true
elseif key == UInt32('r') || key == UInt32('R')
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One consideration of this PR would be that if we can remove r key from this Revise integration. @timholy can I hear your idea on this ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, let's not have Revise steal 2 keystrokes. I'm fine with giving r to :remarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants