Minor LibGit2 cleanup #35466
Merged
Minor LibGit2 cleanup #35466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The official git glossary (https://git-scm.com/docs/gitglossary), spells this commit-ish or committish. Since we can't do the former, use the latter consistently. We had three different spellings.
Keno
commented
Apr 14, 2020
| @@ -122,14 +128,13 @@ tree_entry = tree[1] | |||
| blob = LibGit2.GitBlob(tree_entry) | |||
| ``` | |||
| """ | |||
| function GitObject(e::GitTreeEntry) end | |||
There was a problem hiding this comment.
This function was declaring this signature to return nothing, which is obviously wrong. How do I declare it to just document the signature? @fredrikekre or @KristofferC do you know?
There was a problem hiding this comment.
just GitObject(e::GitTreeEntry) I believe.
Use the _bypath function in GitTree getindex rather than opencoding it using the tree walker.
simonbyrne
approved these changes
May 29, 2020
simeonschaub
pushed a commit
to simeonschaub/julia
that referenced
this pull request
Aug 11, 2020
* Fix spelling of committish The official git glossary (https://git-scm.com/docs/gitglossary), spells this commit-ish or committish. Since we can't do the former, use the latter consistently. We had three different spellings. * Minor LibGit2 API improvement Use the _bypath function in GitTree getindex rather than opencoding it using the tree walker.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only user facing change is adding
haskey(::GitTree, path)to go along with getindex, but the internals are refactored.