Use OpenLibm by default on armv7l #32803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staticfloat
force-pushed
the
sf/armv7l_openlibm
branch
from
d8bc01a
to
fca6d64
Compare
ViralBShah
approved these changes
Aug 6, 2019
|
Merging now, as it's not like the rest of the CI matters for this change. |
|
Judging by reports in #32257 (comment) it looks like this fixes some client code on armv7l, we can consider this an implementation-detail/bugfix IMO, and backport this to 1.1 and 1.2 to un-break code in future releases, IMO. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to have problems with openlibm on armv7l, but we fixed those a few years ago. Let's be consistent, and use openlibm everywhere we can.