Use new binary Artifact infrastructure #187
Conversation
|
@SimonDanisch went ahead and updated your PR, hope you don't mind. Tests look good and are passing. |
|
What's the current policy with regards to 1.3 updates and binary builder. E.g. should we merge this PR to take advantage of the new infrastructure? |
|
@giordano thanks for the review! I addressed everything. Let me know if it now has your approval. |
|
|
||
| [compat] | ||
| BinaryProvider = "≥ 0.5.0" | ||
| julia = "≥ 0.7.0" | ||
| julia = "1.3" |
There was a problem hiding this comment.
1.3 hasn't even been released yet. I don't think we should drop support for 1.0 and later.
There was a problem hiding this comment.
How do you propose to use the new infrastructure?
People can still use SpecialFunctions on < Julia 1.3 . This was partly my question #187 (comment)
There was a problem hiding this comment.
We can also branch and backport bugfixes to versions compatible with < Julia 1.3?
There was a problem hiding this comment.
How do you propose to use the new infrastructure?
Don't bother yet, at least until 1.3 is released and we're confident that there won't be necessary bugfixes or anything that apply to previous versions of Julia.
There was a problem hiding this comment.
Anyway I think it's good to have these early pull requests to test the new framework and maybe let brave users try it if they want 🙂
There was a problem hiding this comment.
Yeah, don't really expected this to get merged - But I needed it anyways as a fork ;)
|
I'm going to merge this now that 1.3 is released after tests pass |
Project.toml
Outdated
|
|
||
| [compat] | ||
| BinaryProvider = "≥ 0.5.0" | ||
| julia = "≥ 0.7.0" | ||
| julia = "≥ 1.3" |
There was a problem hiding this comment.
| julia = "≥ 1.3" | |
| julia = "1.3" |
Also need compatibility for the openspecfun version
There was a problem hiding this comment.
https://github.com/JuliaRegistries/General/blob/master/O/OpenSpecFun_jll/Versions.toml
OpenSpecFun_jll = "0.5.3" for the minimum Ok ?
There was a problem hiding this comment.
≥ means literally any Julia version at or after 1.3.0. Omitting it uses the implicit caret specifier, which gives you only semver-compatible versions. That's important because we don't want this version to be installable on a theoretical future Julia 2.0, for example.
There was a problem hiding this comment.
OpenSpecFun_jll = "0.5.3" for the minimum Ok ?
Yep that works
There was a problem hiding this comment.
One more question, does setting OpenSpecFun_jll = "0.5.3" allow any version of the package up to and including 1.x ?
There was a problem hiding this comment.
See https://julialang.github.io/Pkg.jl/v1/compatibility/. In this case, it fixes OpenSpecFun_jll to 0.5.3, which is good, since we want to ensure we're using a specific version of the openspecfun library.
No description provided.