Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new binary Artifact infrastructure #187

Merged
merged 13 commits into from
Nov 27, 2019
Merged

Use new binary Artifact infrastructure #187

merged 13 commits into from
Nov 27, 2019

Conversation

musm
Copy link
Contributor

@musm musm commented Oct 8, 2019

No description provided.

@musm
Copy link
Contributor Author

musm commented Oct 8, 2019

@SimonDanisch went ahead and updated your PR, hope you don't mind. Tests look good and are passing.

@musm
Copy link
Contributor Author

musm commented Oct 8, 2019

What's the current policy with regards to 1.3 updates and binary builder. E.g. should we merge this PR to take advantage of the new infrastructure?

.drone.jsonnet Outdated Show resolved Hide resolved
.drone.yml Outdated Show resolved Hide resolved
src/SpecialFunctions.jl Outdated Show resolved Hide resolved
@musm
Copy link
Contributor Author

musm commented Oct 8, 2019

@giordano thanks for the review! I addressed everything. Let me know if it now has your approval.

Copy link
Member

@giordano giordano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me if tests are passing!


[compat]
BinaryProvider = "≥ 0.5.0"
julia = "≥ 0.7.0"
julia = "1.3"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.3 hasn't even been released yet. I don't think we should drop support for 1.0 and later.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you propose to use the new infrastructure?
People can still use SpecialFunctions on < Julia 1.3 . This was partly my question #187 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also branch and backport bugfixes to versions compatible with < Julia 1.3?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you propose to use the new infrastructure?

Don't bother yet, at least until 1.3 is released and we're confident that there won't be necessary bugfixes or anything that apply to previous versions of Julia.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyway I think it's good to have these early pull requests to test the new framework and maybe let brave users try it if they want 🙂

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, don't really expected this to get merged - But I needed it anyways as a fork ;)

@musm musm changed the title Update to 1.3 Use new binary Artifact infrastructure Oct 8, 2019
@musm
Copy link
Contributor Author

musm commented Nov 27, 2019

I'm going to merge this now that 1.3 is released after tests pass

Project.toml Outdated

[compat]
BinaryProvider = "≥ 0.5.0"
julia = "≥ 0.7.0"
julia = "≥ 1.3"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
julia = "1.3"
julia = "1.3"

Also need compatibility for the openspecfun version

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the unnecessary?

Copy link
Contributor Author

@musm musm Nov 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

means literally any Julia version at or after 1.3.0. Omitting it uses the implicit caret specifier, which gives you only semver-compatible versions. That's important because we don't want this version to be installable on a theoretical future Julia 2.0, for example.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OpenSpecFun_jll = "0.5.3" for the minimum Ok ?

Yep that works

Copy link
Contributor Author

@musm musm Nov 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more question, does setting OpenSpecFun_jll = "0.5.3" allow any version of the package up to and including 1.x ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://julialang.github.io/Pkg.jl/v1/compatibility/. In this case, it fixes OpenSpecFun_jll to 0.5.3, which is good, since we want to ensure we're using a specific version of the openspecfun library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants