Skip to content

Conversation

@helgee
Copy link
Contributor

@helgee helgee commented Nov 27, 2017

Currently links in docstrings are rendered like this:

[Google](https://google.com) -> Google which makes them unusable from the terminal.

This PR changes this to:

[Google](https://google.com) -> Google (https://google.com)

@helgee helgee closed this Nov 27, 2017
@helgee helgee reopened this Nov 27, 2017
@helgee
Copy link
Contributor Author

helgee commented Nov 27, 2017

macOS and CircleCI failures are unrelated.

@KristofferC KristofferC merged commit 5d7ecf9 into JuliaLang:master Nov 28, 2017
@helgee helgee deleted the terminal-md-links branch November 29, 2017 19:28
@KristofferC
Copy link
Member

This should probably ignore @ref links.

@nalimilan
Copy link
Member

To give more context: @ref links now appear as (@ref), which is annoying and confusing.

@helgee
Copy link
Contributor Author

helgee commented Dec 16, 2017

See #25132

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants