Skip to content

Render URL and name of Markdown links in terminal #24803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KristofferC merged 1 commit into from
Nov 28, 2017
Merged

Render URL and name of Markdown links in terminal #24803

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion base/markdown/render/terminal/render.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ end
terminline(io::IO, f::Footnote) = with_output_format(:bold, terminline, io, "[^$(f.id)]")

function terminline(io::IO, md::Link)
terminline(io, md.text)
terminline(io, "$(terminline(md.text)) ($(md.url))")
end

function terminline(io::IO, code::Code)
Expand Down
2 changes: 1 addition & 1 deletion test/markdown.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ World""" |> plain == "Hello\n\n---\n\nWorld\n"

# multiple whitespace is ignored
@test sprint(term, md"a b") == " a b\n"
@test sprint(term, md"[x](https://julialang.org)") == " x\n"
@test sprint(term, md"[x](https://julialang.org)") == " x (https://julialang.org)\n"
@test sprint(term, md"![x](https://julialang.org)") == " (Image: x)\n"

# enumeration is normalized
Expand Down