RFC: deprecate RopeString

base/deprecated.jl

@@ -692,3 +692,56 @@ function require_filename(name::AbstractString)
 end
 const reload = require
 export reload
+
+## ropes for efficient concatenation, etc. ##
+
+immutable RopeString <: AbstractString
+    head::AbstractString
+    tail::AbstractString
+    depth::Int32
+    endof::Int
+
+    function _new(h, t, d, e)
+        depwarn("`RopeString` is deprecated, use `string` instead", :RopeString)
+        new(h, t, d, e)
+    end
+
+    RopeString(h::RopeString, t::RopeString) =
+        strdepth(h.tail) + strdepth(t) < strdepth(h.head) ?
+            RopeString(h.head, RopeString(h.tail, t)) :
+            _new(h, t, max(h.depth,t.depth)+1, endof(h)+endof(t))
+
+    RopeString(h::RopeString, t::AbstractString) =
+        strdepth(h.tail) < strdepth(h.head) ?
+            RopeString(h.head, RopeString(h.tail, t)) :
+            _new(h, t, h.depth+1, endof(h)+endof(t))
+
+    RopeString(h::AbstractString, t::RopeString) =
+        strdepth(t.head) < strdepth(t.tail) ?
+            RopeString(RopeString(h, t.head), t.tail) :
+            _new(h, t, t.depth+1, endof(h)+endof(t))
+
+    RopeString(h::AbstractString, t::AbstractString) =
+        _new(h, t, 1, endof(h)+endof(t))
+end
+RopeString(s::AbstractString) = RopeString(s,"")
+
+strdepth(s::AbstractString) = 0
+strdepth(s::RopeString) = s.depth
+
+function next(s::RopeString, i::Int)
+    eh = endof(s.head)
+    if i <= eh
+        return next(s.head, i)
+    else
+        c, j = next(s.tail, i-eh)
+        return c, j+eh
+    end
+end
+
+endof(s::RopeString) = s.endof
+length(s::RopeString) = length(s.head) + length(s.tail)
+write(io::IO, s::RopeString) = (write(io, s.head); write(io, s.tail))
+sizeof(s::RopeString) = sizeof(s.head) + sizeof(s.tail)
+
+export RopeString

base/exports.jl

@@ -90,7 +90,6 @@ export
     RemoteRef,
     RepString,
     RevString,
-    RopeString,
     RoundFromZero,
     RoundDown,
     RoundingMode,

base/strings/types.jl

@@ -176,49 +176,3 @@ function repeat(s::ByteString, r::Integer)
 end
 
 (^)(s::AbstractString, r::Integer) = repeat(s,r)
-
-## ropes for efficient concatenation, etc. ##
-
-immutable RopeString <: AbstractString
-    head::AbstractString
-    tail::AbstractString
-    depth::Int32
-    endof::Int
-
-    RopeString(h::RopeString, t::RopeString) =
-        strdepth(h.tail) + strdepth(t) < strdepth(h.head) ?
-            RopeString(h.head, RopeString(h.tail, t)) :
-            new(h, t, max(h.depth,t.depth)+1, endof(h)+endof(t))
-
-    RopeString(h::RopeString, t::AbstractString) =
-        strdepth(h.tail) < strdepth(h.head) ?
-            RopeString(h.head, RopeString(h.tail, t)) :
-            new(h, t, h.depth+1, endof(h)+endof(t))
-
-    RopeString(h::AbstractString, t::RopeString) =
-        strdepth(t.head) < strdepth(t.tail) ?
-            RopeString(RopeString(h, t.head), t.tail) :
-            new(h, t, t.depth+1, endof(h)+endof(t))
-
-    RopeString(h::AbstractString, t::AbstractString) =
-        new(h, t, 1, endof(h)+endof(t))
-end
-RopeString(s::AbstractString) = RopeString(s,"")
-
-strdepth(s::AbstractString) = 0
-strdepth(s::RopeString) = s.depth
-
-function next(s::RopeString, i::Int)
-    eh = endof(s.head)
-    if i <= eh
-        return next(s.head, i)
-    else
-        c, j = next(s.tail, i-eh)
-        return c, j+eh
-    end
-end
-
-endof(s::RopeString) = s.endof
-length(s::RopeString) = length(s.head) + length(s.tail)
-write(io::IO, s::RopeString) = (write(io, s.head); write(io, s.tail))
-sizeof(s::RopeString) = sizeof(s.head) + sizeof(s.tail)

test/strings/types.jl

@@ -190,7 +190,3 @@ let
     @test srep[7] == 'β'
     @test_throws BoundsError srep[8]
 end
-
-## Rope strings ##
-
-@test sizeof(RopeString("abc","def")) == 6