Skip to content

RFC: deprecate RopeString #12330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 27, 2015
Merged

RFC: deprecate RopeString #12330

merged 1 commit into from
Jul 27, 2015

Conversation

JeffBezanson
Copy link
Member

While RevString and RepString see a small amount of use in Base, RopeString doesn't seem to be used at all. I think we should deprecate it in 0.4, then maybe move it to examples.

@ArchRobison
Copy link
Contributor

Deprecating it seems reasonable to me. Ropes have always seemed like a cool idea, but I've never used them in real code. I suspect that cache effects on modern architectures make them less interesting than they once were.

@ScottPJones
Copy link
Contributor

👏 👍

@StefanKarpinski
Copy link
Member

+1, although it's interesting that this was concurrent with suggesting a potential ConcatString type.

@JeffBezanson
Copy link
Member Author

I didn't exactly "suggest" a ConcatString type; in fact I described it as "not appealing".

@StefanKarpinski
Copy link
Member

Right, "brought up" then.

JeffBezanson added a commit that referenced this pull request Jul 27, 2015
@JeffBezanson JeffBezanson merged commit 38a51fc into master Jul 27, 2015
@ivarne
Copy link
Member

ivarne commented Jul 27, 2015

I understand the desire to move quickly, but as this doesn't fix anything urgent, I'd appreciate at least 24 hours between opening the PR and merging. That would give our global community a (theoretical) chance to raise reasonable objections.

PS: I'll retract my comment if the 0.4 feature freeze is imminent, so that this really would have slowed things down if it had waited longer. It seems like a pretty safe change.

@yuyichao yuyichao deleted the jb/deprecateropestring branch July 27, 2015 22:06
@ScottPJones
Copy link
Contributor

I actually had this in a previous PR, but Tony wouldn't let me do it 😀

@tkelman
Copy link
Contributor

tkelman commented Jul 28, 2015

Deprecation is fine, your previous PR flat-out deleted it from what I remember.

@ScottPJones
Copy link
Contributor

Yes, and I would have moved it to a Package as you'd suggested, but just put it back in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants