Skip to content

Fix stack overflow in safe_realpath #4313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2025
Merged

Fix stack overflow in safe_realpath #4313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/utils.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,6 @@ end

# try to call realpath on as much as possible
function safe_realpath(path)
isempty(path) && return path
if ispath(path)
try
return realpath(path)
Expand All @@ -128,6 +127,8 @@ function safe_realpath(path)
end
end
a, b = splitdir(path)
# path cannot be reduced at the root or drive, avoid stack overflow
isempty(b) && return path
return joinpath(safe_realpath(a), b)
end

Expand Down
3 changes: 2 additions & 1 deletion test/misc.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,9 @@ end
end

@testset "safe_realpath" begin
realpath(Sys.BINDIR) == Pkg.safe_realpath(Sys.BINDIR)
# issue #3085
for p in ("", "some-non-existing-path")
for p in ("", "some-non-existing-path", "some-non-existing-drive:")
@test p == Pkg.safe_realpath(p)
end
end
Expand Down