Fix stack overflow in safe_realpath
#4313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes JuliaLang#3085 That issue was already closed by JuliaLang#3087 but I still ran into the same issue, it seems the fix was wrong. The stack overflow can still be triggered on Windows by ```jl using Pkg: safe_realpath safe_realpath("some-non-existing-drive:") ``` It keeps on recursing trying to make it smaller with `splitdir`, but it can't. We know we cannot make it smaller if the returned "filename" is empty. On Linux we have: ```jl julia> splitdir("/") ("/", "") ``` On Windows: ```jl julia> splitdir("C://") ("C:/", "") ```
KristofferC
approved these changes
Jul 7, 2025
KristofferC
pushed a commit
that referenced
this pull request
Jul 12, 2025
(cherry picked from commit 6ae6499)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3085
That issue was already closed by #3087 but I still ran into the same issue, it seems the fix was wrong.
The stack overflow can still be triggered on Windows by
It keeps on recursing trying to make it smaller with
splitdir, but it can't. We know we cannot make it smaller if the returned "filename" is empty.On Linux we have:
On Windows: