Skip to content

fix not hardcoding "Project.toml" when fixing up extensions in manifest #3851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 23, 2024
Merged

fix not hardcoding "Project.toml" when fixing up extensions in manifest #3851

merged 3 commits into from
Jul 23, 2024

Conversation

@KristofferC
Copy link
Member

@KristofferC KristofferC commented Mar 21, 2024

Fixes #3815

@KristofferC
Copy link
Member Author

KristofferC commented Mar 25, 2024 •
edited
Loading

CI error in windows seems relevant...

  SystemError: longpath: The system cannot find the path specified. 
  Stacktrace:
    [1] windowserror(p::Symbol, code::UInt32; extrainfo::Nothing)
      @ Base .\error.jl:191
    [2] windowserror
      @ .\error.jl:190 [inlined]
    [3] longpath(path::String)
      @ Base.Filesystem .\path.jl:479
    [4] isfile_casesensitive(path::String)
      @ Base .\loading.jl:15
    [5] locate_project_file
      @ .\loading.jl:582 [inlined]

Keno added a commit to JuliaRegistries/RegistryTools.jl that referenced this pull request Apr 3, 2024
@Keno
Add path to Project struct
66ecc73 
In anticipation of fixing the equivalent of JuliaLang/Pkg.jl#3851
in LocalReigstry.jl.
@Keno Keno mentioned this pull request Apr 3, 2024
Closed
@IanButterworth IanButterworth mentioned this pull request Apr 11, 2024
Merged
6 tasks
@kimikage
Copy link

kimikage commented Jun 14, 2024

xref: JuliaLang/julia#54799

@IanButterworth IanButterworth mentioned this pull request Jul 13, 2024
Merged
10 tasks
@IanButterworth
Copy link
Member

IanButterworth commented Jul 23, 2024

The fix is JuliaLang/julia#55220

@KristofferC
Copy link
Member Author

KristofferC commented Jul 23, 2024

Can we fix it on this side as well by calling abspath?

@IanButterworth IanButterworth merged commit 8875120 into master Jul 23, 2024
@IanButterworth IanButterworth deleted the kc/project_hardcode branch July 23, 2024 18:19
@IanButterworth IanButterworth mentioned this pull request Jul 23, 2024
Merged
5 tasks
IanButterworth added a commit that referenced this pull request Jul 23, 2024
@KristofferC @IanButterworth
fix not hardcoding "Project.toml" when fixing up extensions in manife…
861384c 
…st (#3851)

* fix not hardcoding "Project.toml" when fixing up extensions in manifest file

* abspath to be extra safe

---------

Co-authored-by: KristofferC <kristoffer.carlsson@juliacomputing.com>
Co-authored-by: Ian Butterworth <i.r.butterworth@gmail.com>
(cherry picked from commit 8875120)
IanButterworth added a commit that referenced this pull request Jul 23, 2024
@KristofferC @IanButterworth
fix not hardcoding "Project.toml" when fixing up extensions in manife…
ad1f1ac 
…st (#3851)

* fix not hardcoding "Project.toml" when fixing up extensions in manifest file

* abspath to be extra safe

---------

Co-authored-by: KristofferC <kristoffer.carlsson@juliacomputing.com>
Co-authored-by: Ian Butterworth <i.r.butterworth@gmail.com>
This was referenced Jul 23, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IanButterworth IanButterworth IanButterworth approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[extensions] is ignored in JuliaProject.toml

3 participants

@KristofferC @kimikage @IanButterworth