Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A bunch of stuff for 0.7 #435

Merged
merged 8 commits into from
Dec 21, 2017
Merged

A bunch of stuff for 0.7 #435

merged 8 commits into from
Dec 21, 2017

Conversation

ararslan
Copy link
Member

No description provided.

@ararslan
Copy link
Member Author

Nightly tests will need #432 in order to pass here.

@omus omus mentioned this pull request Dec 21, 2017
Merged
@ararslan ararslan merged commit 7a64c3f into master Dec 21, 2017
@ararslan ararslan deleted the aa/0.7 branch December 21, 2017 06:21
fredrikekre
fredrikekre reviewed Dec 21, 2017
View reviewed changes
src/Compat.jl
@static if !isdefined(Base, :axes)
const axes = Base.indices
export axes
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have

else
    import Base.axes
end

such that you can overload Compat.axes on 0.6 too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind... I confused myself.

@tknopp
Copy link

tknopp commented Dec 29, 2017

@ararslan: This seem to have broken ImageAxes package (see https://discourse.julialang.org/t/issues-with-axisarrays-on-0-6/8064). Not sure how and where to fix.

@ararslan
Copy link
Member Author

I assume it's similarly broken on 0.7 then, since Base exports axes on 0.7. I'm not familiar with ImageAxes, but if it wouldn't be type piracy then I recommend extending axes from Compat.

@omus
Copy link
Member

omus commented Dec 29, 2017

If we didn't export axes from Compat then the change wouldn't impact other packages. That is kind of a work around however.

@ararslan
Copy link
Member Author

If we didn't export axes from Compat then the change wouldn't impact other packages

Indeed, see #442.

@tknopp
Copy link

tknopp commented Dec 29, 2017

Many thanks @ararslan. For 0.7 we now need discussion on the meaning of this function. Either base or AxisArrays need to rename it. Since there are now so many threads out there: Where should be initiate that discussion.

@tknopp
Copy link

tknopp commented Dec 29, 2017

maybe here JuliaLang/julia#25057
is the best discussion place

@tknopp tknopp mentioned this pull request Dec 29, 2017
Merged
martinholters added a commit that referenced this pull request Oct 1, 2019
@martinholters
Mark Compat.Printf from #435 for deprecation
f1396ea
martinholters added a commit that referenced this pull request Oct 1, 2019
@martinholters
Drop compat code for IterativeEigensolvers from #435
cb9843d
martinholters added a commit that referenced this pull request Oct 4, 2019
@martinholters
Drop Compat.SuiteSparse from #435
3ed2409
martinholters added a commit that referenced this pull request Oct 4, 2019
@martinholters
Drop compat code for AbstractDict from #435
20b0973
martinholters added a commit that referenced this pull request Oct 4, 2019
@martinholters
Drop compat for axes #435 and #442
46389bf
martinholters added a commit that referenced this pull request Oct 4, 2019
@martinholters
Drop compat code for Nothing and Cvoid from #435
f267e97
martinholters added a commit that referenced this pull request Oct 4, 2019
@martinholters
Drop compat code for AbstractDict from #435
8d22dd0
martinholters added a commit that referenced this pull request Oct 4, 2019
@martinholters
Drop compat for axes #435 and #442
0f3f09f
martinholters added a commit that referenced this pull request Oct 4, 2019
@martinholters
Drop compat code for Nothing and Cvoid from #435
a8c0a75
martinholters added a commit that referenced this pull request Oct 4, 2019
@martinholters
Drop compat code for Some from #435 and #563
9c6ae72 
But only mark `notnothing` for deprecation.
martinholters added a commit that referenced this pull request Oct 8, 2019
@martinholters
Mark Compat.Printf from #435 for deprecation
19735ae
martinholters added a commit that referenced this pull request Oct 8, 2019
@martinholters
Drop compat code for IterativeEigensolvers from #435
b95638c
martinholters added a commit that referenced this pull request Oct 8, 2019
@martinholters
Drop Compat.SuiteSparse from #435
12b9161
martinholters added a commit that referenced this pull request Oct 8, 2019
@martinholters
Drop compat code for AbstractDict from #435
27a178c
martinholters added a commit that referenced this pull request Oct 8, 2019
@martinholters
Drop compat for axes #435 and #442
5522d24
martinholters added a commit that referenced this pull request Oct 8, 2019
@martinholters
Drop compat code for Nothing and Cvoid from #435
d744d24
martinholters added a commit that referenced this pull request Oct 8, 2019
@martinholters
Drop compat code for Some from #435 and #563
f93afea 
But only mark `notnothing` for deprecation.
martinholters added a commit that referenced this pull request Oct 13, 2019
@martinholters
Drop support for Julia versions <1.0 (#665)
4fa5519 
* Bump required Julia version to 1.0

* Remove compatibility support code for:
  * `at-__MODULE__` (from #363)
  * `devnull`, `stdin`, `stdout`, and `stderr` from #499
  * `at-nospecialize` (from #385 and #409)
  * `isabstracttype` and `isconcretetype` (from #477)
  * `invokelatest` from #424
  * array-like access to `Cmd` from #379
  * `Val(n)` and `ntuple`/`reshape` with `Val` from #381 and #399
  * `logdet(::Any)` fallback from #382
  * `chol(::UniformScaling)` from #382
  * `pushfirst!`, `popfirst!` from #444
  * `fieldcount` from #386
  * `read(obj, ::Type{String})` from #385 and #580
  * `InexactError`, `DomainError`, and `OverflowError` constructors from #393
  * `corrected` kw arg to `cov` from #401
  * `adjoint` from #401
  * `partialsort` from #401
  * `pairs` from #428
  * `AbstractRange` from #400
  * `rtoldefault` from #401
  * `Dates.Period` rounding from #462
  * `IterativeEigensolvers` from #435
  * `occursin` from #520
  * `Char` concatenation from #406
  * `BitSet` from #407
  * `diagm` and `spdiagm` with pairs from #408
  * `Array` c'tors from `UniformScaling` from #412 and #438
  * `IOContext` ctor taking pairs from #427
  * `undef` from #417 and #514
  * `get` on `ENV` from #430
  * `ComplexF...` from #431
  * `tr` from #614
  * `textwidth` from #644
  * `isnumeric` from #543
  * `AbstractDict` from #435
  * `axes` #435 and #442
  * `Nothing` and `Cvoid` from #435
  * `Compat.SuiteSparse` from #435
  * `invpermute!` from #445
  * `replace` with a pair from #445
  * `copyto!` from #448
  * `contains` from #452
  * `CartesianIndices` and `LinearIndices` from #446, #455, and #524
  * `findall` from #466 (and #467).
  * `argmin` and `argmax` from #470, #472, and #622
  * `parentmodule` from #461
  * `codeunits` from #474
  * `nameof` from #471
  * `GC` from #477
  * `AbstractDisplay` from #482
  * `bytesavailable` from #483
  * `firstindex` and `lastindex` from #480 and #494
  * `printstyled` from #481
  * `hasmethod` from #486
  * `objectid` from #486
  * `Compat.find*` from #484 and #513
  * `repr` and `showable` from #497
  * `Compat.names` from #493 and #505
  * `Compat.round` and friends #500, #530, and #537
  * `IOBuffer` from #501 and #504
  * `range` with kw args and `LinRange` from #511
  * `cp` and `mv` from #512
  * `indexin` from #515
  * `isuppercase` and friends from #516
  * `dims` and `init` kwargs from #518, #528, #590, #592, and #613
  * `selectdim` from #522 and #531
  * `repeat` from #625
  * `fetch(::Task)` from #549
  * `isletter` from #542
  * `isbitstype` from #560
  * `at-cfunction` from #553 and #566
  * `codeunit` and `thisind` and friends from #573
  * `something` from #562
  * `permutedims` from #582
  * `atan` from #574
  * `split` and `rsplit` from #572
  * `mapslices` from #588
  * `floatmin` and `floatmax` from #607
  * `dropdims` from #618
  * required keyword arguments from #586
  * `CartesianRange` in `at-compat` from #377
  * `finalizer` from #416
  * `readline`, `eachline`, and `readuntil` from #477, #541, and #575
  * curried `isequal`, `==`, and `in` from #517
  * `Some` from #435 and #563
  * `at-warn` and friends from #458

* Remove old deprecations

* Deprecate:
  * `Compat.Sockets` from #545 and #594
  * `TypeUtils` from #304
  * `macros_have_sourceloc` from #355
  * `Compat.Sys` from #380, #433, and #552
  * `Compat.MathConstants` from #401
  * `Compat.Test`, `Compat.SharedArrays`, `Compat.Mmap`, and `Compat.DelimitedFiles` from #404
  * `Compat.Dates` from #413
  * `Compat.Libdl` from #465 (and #467)
  * `AbstractDateTime` from #443
  * `Compat.Printf` from #435
  * `Compat.LinearAlgebra` from #463
  * `Compat.SparseArrays` from #459
  * `Compat.Random` from #460, #601, and #647
  * `Compat.Markdown` from #492
  * `Compat.REPL` from #469
  * `Compat.Serialization` from #473
  * `Compat.Statistics` from #583
  * `Fix2` from #517
  * `Compat.Base64` from #418
  * `Compat.Unicode` from #432 and #507
  * `notnothing` from #435 and #563
  * `Compat.IteratorSize` and `Compat.IteratorEltype` from #451
  * `enable_debug(::Bool)` from #458
  * `Compat.Distributed` from #477
  * `Compat.Pkg` from #485
  * `Compat.InteractiveUtils` from #485
  * `Compat.LibGit2` from #487
  * `Compat.UUIDs` from #490
  * `Compat.qr` from #534
  * `Compat.rmul!` from #546
  * `Compat.norm` abd friends from #577

* Remove obsolete README entry, missed in #385

* Remove obsolete tests (e.g. missed in #372)

* Remove obsolete `VERSION` conditionals and some minor clean-up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredrikekre fredrikekre fredrikekre left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ararslan @tknopp @omus @fredrikekre