Dropping 0.4 #372

rofinn · 2017-06-21T19:25:22Z

I'll leave updating the test cases till after this has been reviewed to minimize breaking existing functionality.

Fixes #361

…s and appveyor.

stevengj · 2017-06-21T22:21:32Z

Don't forget to remove things from the README that are no longer needed for v0.5+.

stevengj · 2017-06-22T16:22:35Z

README.md

@@ -119,8 +94,6 @@ Currently, the `@compat` macro supports the following syntaxes:

 * `foreach`, similar to `map` but when the return value is not needed ([#13744])


foreach (JuliaLang/julia#13774) was added in 0.5 too.

stevengj · 2017-06-22T16:23:00Z

README.md

@@ -119,8 +94,6 @@ Currently, the `@compat` macro supports the following syntaxes:

 * `foreach`, similar to `map` but when the return value is not needed ([#13744])

-* `walkdir`, returns an iterator that walks the directory tree of a directory ([#13707])
-
 * `allunique`, checks whether all elements in an iterable appear only once ([#15914])


allunique was added in 0.5

stevengj · 2017-06-22T16:23:18Z

README.md

@@ -119,8 +94,6 @@ Currently, the `@compat` macro supports the following syntaxes:

 * `foreach`, similar to `map` but when the return value is not needed ([#13744])

-* `walkdir`, returns an iterator that walks the directory tree of a directory ([#13707])
-
 * `allunique`, checks whether all elements in an iterable appear only once ([#15914])

 * `Base.promote_eltype_op` is available as `Compat.promote_eltype_op`


added in 0.5

stevengj · 2017-06-22T16:23:57Z

README.md

-* `bytestring(::Ptr, ...)` has been replaced with `unsafe_string`
-
-* `super` is now `supertype` ([#14338])
-
 * `qr(A, pivot=b)` is now `qr(A, Val{b})`, likewise for `qrfact` and `qrfact!`


added in 0.5

stevengj · 2017-06-22T16:24:11Z

README.md

-* `Compat.LinAlg.checksquare` ([#14601])
-
-* `issym` is now `issymmetric` ([#15192])
-
 * `istext` is now `istextmime` ([#15708])


added in 0.5

stevengj · 2017-06-22T16:24:24Z

README.md

 * `istext` is now `istextmime` ([#15708])

-* `symbol` is now `Symbol` ([#16154])
-
 * `write(::IO, ::Ptr, len)` is now `unsafe_write` ([#14766])


added in 0.5

stevengj · 2017-06-22T16:25:42Z

README.md

-* `slice` is now `view` ([#16972]); do `import Compat.view` and then use `view` normally without the `@compat` macro
-
-* `fieldoffsets` has been deprecated in favor of `fieldoffset` ([#14777])
-
 * `print_escaped` is now another method of `escape_string`, `print_unescaped` a method of `unescape_string`, and `print_joined` a method of `join` ([#16603])


added in 0.5

stevengj · 2017-06-22T16:26:04Z

README.md

-* `slice` is now `view` ([#16972]); do `import Compat.view` and then use `view` normally without the `@compat` macro
-
-* `fieldoffsets` has been deprecated in favor of `fieldoffset` ([#14777])
-
 * `print_escaped` is now another method of `escape_string`, `print_unescaped` a method of `unescape_string`, and `print_joined` a method of `join` ([#16603])

 * `writemime` has been merged into `show` ([#16563]). Note that to extend this function requires `@compat`; see the [Supported Syntax](#supported-syntax) section for more information


renamed in 0.5

stevengj · 2017-06-22T16:26:41Z

README.md

@@ -221,8 +169,6 @@ Currently, the `@compat` macro supports the following syntaxes:

 ## New macros

-* `@static` has been added ([#16219])
-
 * `@functorize` (not present in any Julia version) takes a function (or operator) and turns it into a functor object if one is available in the used Julia version. E.g. something like `mapreduce(Base.AbsFun(), Base.MulFun(), x)` can now be written as `mapreduce(@functorize(abs), @functorize(*), x)`, and `f(::Base.AbsFun())` as `f(::typeof(@functorize(abs)))`, to work across different Julia versions. `Func{1}` can be written as `supertype(typeof(@functorize(abs)))` (and so on for `Func{2}`), which will fall back to `Function` on Julia 0.5.


@functorize is obsolete in 0.5

the no-op should probably be left in but with a deprecation warning to avoid hard-breaking anyone that was using it

For 0.5+ the existing code does:

macro functorize(f) f === :scalarmax ? :(Base.scalarmax) : f === :scalarmin ? :(Base.scalarmin) : f === :centralizedabs2fun ? :(primarytype(typeof(Base.centralizedabs2fun(0)))) : f end

Should this be changed to something like:

macro functorize(f) return quote Base.depwarn("@functorize is obsolete as of 0.5", Symbol("@functorize")) f end end

?

stevengj · 2017-06-22T16:27:01Z

README.md

@@ -221,8 +169,6 @@ Currently, the `@compat` macro supports the following syntaxes:

 ## New macros

-* `@static` has been added ([#16219])
-
 * `@functorize` (not present in any Julia version) takes a function (or operator) and turns it into a functor object if one is available in the used Julia version. E.g. something like `mapreduce(Base.AbsFun(), Base.MulFun(), x)` can now be written as `mapreduce(@functorize(abs), @functorize(*), x)`, and `f(::Base.AbsFun())` as `f(::typeof(@functorize(abs)))`, to work across different Julia versions. `Func{1}` can be written as `supertype(typeof(@functorize(abs)))` (and so on for `Func{2}`), which will fall back to `Function` on Julia 0.5.

 * `Compat.@blasfunc` makes functionality of `Base.LinAlg.BLAS.@blasfunc` available on older Julia versions


added in 0.5

stevengj · 2017-06-22T16:27:13Z

README.md

-  `Base.FS` on Julia 0.4 and `Base.Filesystem` on Julia 0.5.
-
-* `cov` and `cor` don't allow keyword arguments anymore. Loading Compat defines compatibility methods for the new API ([#13465])
-
 * On versions of Julia that do not contain a Base.Threads module, Compat defines a Threads module containing a no-op `@threads` macro.

 * `Base.SingleAsyncWork` is now `Base.AsyncCondition`


added in 0.5

stevengj · 2017-06-22T16:27:24Z

README.md

-  `Base.SingleAsyncWork` on Julia 0.4 and `Base.AsyncCondition` on Julia 0.5.
-
-* `repeat` now accepts any `AbstractArray` ([#14082]): `Compat.repeat` supports this new API on Julia 0.4, and calls `Base.repeat` on 0.5.
+  `Base.AsyncCondition` on Julia 0.5.

 * `OS_NAME` is now `Sys.KERNEL`. OS information available as `is_apple`, `is_bsd`, `is_linux`, `is_unix`, and `is_windows` ([#16219])


added in 0.5

stevengj · 2017-06-22T16:27:50Z

README.md

-  `Base.SingleAsyncWork` on Julia 0.4 and `Base.AsyncCondition` on Julia 0.5.
-
-* `repeat` now accepts any `AbstractArray` ([#14082]): `Compat.repeat` supports this new API on Julia 0.4, and calls `Base.repeat` on 0.5.
+  `Base.AsyncCondition` on Julia 0.5.

 * `OS_NAME` is now `Sys.KERNEL`. OS information available as `is_apple`, `is_bsd`, `is_linux`, `is_unix`, and `is_windows` ([#16219])

 * `cholfact`, `cholfact!`, and `chol` require that input is either `Hermitian`, `Symmetric`


added in 0.5

rofinn · 2017-06-25T17:38:11Z

Travis failed to download nightly on macos.

rofinn · 2017-06-30T21:25:15Z

Does anyone see any other issues with this?

tkelman · 2017-07-05T00:51:04Z

README.md

@@ -81,31 +73,12 @@ Currently, the `@compat` macro supports the following syntaxes:

 * `@compat Base.IndexStyle(::Type{<:MyArray}) = IndexLinear()` and `@compat Base.IndexStyle(::Type{<:MyArray}) = IndexCartesian()` to define traits for abstract arrays, replacing the former `Base.linearindexing{T<:MyArray}(::Type{T}) = Base.LinearFast()` and `Base.linearindexing{T<:MyArray}(::Type{T}) = Base.LinearSlow()`, respectively.

-* `Compat.collect(A)` returns an `Array`, no matter what indices the array `A` has (Julia 0.5 and higher). [#21257]


this seems recent, it just never worked for 0.4?

I guess this should just remove the (Julia 0.5 and higher part).

tkelman · 2017-07-05T00:54:31Z

src/to-be-deprecated.jl

-end
+include("ngenerate.jl")
+using .CompatCartesian
+export @ngenerate, @nsplat


should deprecate these

tkelman · 2017-07-05T00:58:01Z

src/Compat.jl

@@ -690,79 +256,10 @@ end

 export @functorize
 macro functorize(f)


should deprecate this

Should this be moved to to-be-deprecated.jl then?

yeah good idea, since I don't think we want to keep this around forever

On a similar note, should we merge to-be-deprecated.jl and ngenerate.jl into a deprecated.jl file?

…er)' part).

ararslan · 2017-07-15T22:07:59Z

This looks good to me; I think we should go ahead and merge this. Any objections or further comments?

tkelman · 2017-07-16T07:29:14Z

I'm a little concerned that the deprecations being introduced may never be fixed on 0.5 if packages have moved on to being 0.6-only already. Maybe we should make the deprecation warning 0.6-only since they won't be removed until an 0.6-only version of Compat gets released.

rofinn · 2017-07-17T16:56:57Z

@tkelman Would you be comfortable with an explicit if block in each deprecation?
Example)

if VERSION >= v"0.6.0"
    Base.depwarn(...)
end
# code

tkelman · 2017-07-17T17:58:05Z

yeah that would be fine imo

… on 0.6.

tkelman · 2017-07-18T06:05:28Z

src/Compat.jl

-    const view = slice
-end
+const UTF8String = Core.String
+const ASCIIString = Core.String


we should probably move these to deprecated.jl, have them const for 0.5, deprecate_binding for 0.6

…0.6.

tkelman · 2017-07-18T18:31:04Z

src/Compat.jl

-    end
-else
-    new_style_call_overload(ex::Expr) = false
+function new_style_call_overload(ex::Expr)


just in case anyone was calling it from other packages?

Yeah, I'm not sure why they would, but I figured I should try to err on the side of caution.

tkelman · 2017-07-18T18:34:20Z

Thanks so much for doing this! I think we're good to go here.

ararslan · 2017-07-18T18:55:39Z

I'll wait on #380 and rebase it once this is merged. Easier to rebase that than this.

* new style call overloading (added in #181, removed in #385) * `get(io, s false)` (added in #212, #215, #225, removed in #385) * `.=` (added in #292 and #316, removed in #372)

* Remove at-compat for type aliases Was added in #326, now obsolete as no longer required on minimum supported Julia version 0.6. * Remove at-compat for Nullable construction Was added in #287, now obsolete as no longer required on minimum supported Julia version 0.6. * Remove at-compat for Foo{<:Bar} sugar Was added in #317 (and #336), now obsolete as no longer required on minimum supported Julia version 0.6. * Remove at-compat for index styles Was added in #329, now obsolete as no longer required on minimum supported Julia version 0.6. * Remove at-compat for type declarations Was added in #325, now obsolete as no longer required on minimum supported Julia version 0.6. * Remove unused at-compat helper functions * Remove README entries for removed at-compat functionality * new style call overloading (added in #181, removed in #385) * `get(io, s false)` (added in #212, #215, #225, removed in #385) * `.=` (added in #292 and #316, removed in #372) * Remove `Compat.collect(A)` Was added in #350 and #351, now obsolete as no longer required on minimum supported Julia version 0.6.

* Bump required Julia version to 1.0 * Remove compatibility support code for: * `at-__MODULE__` (from #363) * `devnull`, `stdin`, `stdout`, and `stderr` from #499 * `at-nospecialize` (from #385 and #409) * `isabstracttype` and `isconcretetype` (from #477) * `invokelatest` from #424 * array-like access to `Cmd` from #379 * `Val(n)` and `ntuple`/`reshape` with `Val` from #381 and #399 * `logdet(::Any)` fallback from #382 * `chol(::UniformScaling)` from #382 * `pushfirst!`, `popfirst!` from #444 * `fieldcount` from #386 * `read(obj, ::Type{String})` from #385 and #580 * `InexactError`, `DomainError`, and `OverflowError` constructors from #393 * `corrected` kw arg to `cov` from #401 * `adjoint` from #401 * `partialsort` from #401 * `pairs` from #428 * `AbstractRange` from #400 * `rtoldefault` from #401 * `Dates.Period` rounding from #462 * `IterativeEigensolvers` from #435 * `occursin` from #520 * `Char` concatenation from #406 * `BitSet` from #407 * `diagm` and `spdiagm` with pairs from #408 * `Array` c'tors from `UniformScaling` from #412 and #438 * `IOContext` ctor taking pairs from #427 * `undef` from #417 and #514 * `get` on `ENV` from #430 * `ComplexF...` from #431 * `tr` from #614 * `textwidth` from #644 * `isnumeric` from #543 * `AbstractDict` from #435 * `axes` #435 and #442 * `Nothing` and `Cvoid` from #435 * `Compat.SuiteSparse` from #435 * `invpermute!` from #445 * `replace` with a pair from #445 * `copyto!` from #448 * `contains` from #452 * `CartesianIndices` and `LinearIndices` from #446, #455, and #524 * `findall` from #466 (and #467). * `argmin` and `argmax` from #470, #472, and #622 * `parentmodule` from #461 * `codeunits` from #474 * `nameof` from #471 * `GC` from #477 * `AbstractDisplay` from #482 * `bytesavailable` from #483 * `firstindex` and `lastindex` from #480 and #494 * `printstyled` from #481 * `hasmethod` from #486 * `objectid` from #486 * `Compat.find*` from #484 and #513 * `repr` and `showable` from #497 * `Compat.names` from #493 and #505 * `Compat.round` and friends #500, #530, and #537 * `IOBuffer` from #501 and #504 * `range` with kw args and `LinRange` from #511 * `cp` and `mv` from #512 * `indexin` from #515 * `isuppercase` and friends from #516 * `dims` and `init` kwargs from #518, #528, #590, #592, and #613 * `selectdim` from #522 and #531 * `repeat` from #625 * `fetch(::Task)` from #549 * `isletter` from #542 * `isbitstype` from #560 * `at-cfunction` from #553 and #566 * `codeunit` and `thisind` and friends from #573 * `something` from #562 * `permutedims` from #582 * `atan` from #574 * `split` and `rsplit` from #572 * `mapslices` from #588 * `floatmin` and `floatmax` from #607 * `dropdims` from #618 * required keyword arguments from #586 * `CartesianRange` in `at-compat` from #377 * `finalizer` from #416 * `readline`, `eachline`, and `readuntil` from #477, #541, and #575 * curried `isequal`, `==`, and `in` from #517 * `Some` from #435 and #563 * `at-warn` and friends from #458 * Remove old deprecations * Deprecate: * `Compat.Sockets` from #545 and #594 * `TypeUtils` from #304 * `macros_have_sourceloc` from #355 * `Compat.Sys` from #380, #433, and #552 * `Compat.MathConstants` from #401 * `Compat.Test`, `Compat.SharedArrays`, `Compat.Mmap`, and `Compat.DelimitedFiles` from #404 * `Compat.Dates` from #413 * `Compat.Libdl` from #465 (and #467) * `AbstractDateTime` from #443 * `Compat.Printf` from #435 * `Compat.LinearAlgebra` from #463 * `Compat.SparseArrays` from #459 * `Compat.Random` from #460, #601, and #647 * `Compat.Markdown` from #492 * `Compat.REPL` from #469 * `Compat.Serialization` from #473 * `Compat.Statistics` from #583 * `Fix2` from #517 * `Compat.Base64` from #418 * `Compat.Unicode` from #432 and #507 * `notnothing` from #435 and #563 * `Compat.IteratorSize` and `Compat.IteratorEltype` from #451 * `enable_debug(::Bool)` from #458 * `Compat.Distributed` from #477 * `Compat.Pkg` from #485 * `Compat.InteractiveUtils` from #485 * `Compat.LibGit2` from #487 * `Compat.UUIDs` from #490 * `Compat.qr` from #534 * `Compat.rmul!` from #546 * `Compat.norm` abd friends from #577 * Remove obsolete README entry, missed in #385 * Remove obsolete tests (e.g. missed in #372) * Remove obsolete `VERSION` conditionals and some minor clean-up

rofinn added 3 commits June 21, 2017 12:44

Increased julia minimum requirement and removed 0.4 builds from travi…

d49f187

…s and appveyor.

First pass removing all the pre-0.5 code.

0405750

Fixed up some things so that tests pass again.

08c50c7

tkelman requested review from timholy and tkelman June 21, 2017 20:15

Updated README to remove references to 0.4.

add2fa5

stevengj reviewed Jun 22, 2017

View reviewed changes

Removed a some more syntax for supporting 0.4.

7c5b5f8

rofinn changed the title ~~WIP: Dropping 0.4~~ Dropping 0.4 Jun 25, 2017

tkelman reviewed Jul 5, 2017

View reviewed changes

rofinn added 3 commits July 5, 2017 12:57

Deprecate @ngenerate and @nsplat.

39d0aba

Deprecate @functorize.

b2e64d7

Moved @functorize to to-be-deprecated.jl

fcf2ba3

rofinn added 4 commits July 5, 2017 13:32

Renamed to-be-deprecated.jl -> deprecated.jl

d6baa4e

Merged ngenerate.jl into deprecated.jl

011e015

Fixed accidental deletion in README (vs just the '(Julia 0.5 and high…

832bae3

…er)' part).

Renamed test/to-be-deprecated.jl

d346d79

ararslan approved these changes Jul 14, 2017

View reviewed changes

Added some version checks so that deprecation warning are only thrown…

cf2ef7d

… on 0.6.

tkelman reviewed Jul 18, 2017

View reviewed changes

Added deprecation warnings for KERNEL, UTF8String and ASCIIString on …

f9067f6

…0.6.

tkelman reviewed Jul 18, 2017

View reviewed changes

ararslan merged commit bdf61d8 into JuliaLang:master Jul 19, 2017

yuyichao mentioned this pull request Jul 23, 2017

Drop 0.4 and 0.7 fixes #385

Merged

TotalVerb mentioned this pull request Sep 5, 2017

Add linearindices and indices? #258

Closed

martinholters added a commit that referenced this pull request Oct 8, 2019

Remove long obsolete tests (missed in #372)

4db9884

martinholters added a commit that referenced this pull request Oct 8, 2019

Remove long obsolete tests (missed in #372)

3b0afb9

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dropping 0.4 #372

Dropping 0.4 #372

rofinn commented Jun 21, 2017 •

edited by ararslan

Loading

stevengj commented Jun 21, 2017

stevengj Jun 22, 2017 •

edited

Loading

stevengj Jun 22, 2017

stevengj Jun 22, 2017

stevengj Jun 22, 2017

stevengj Jun 22, 2017

stevengj Jun 22, 2017

stevengj Jun 22, 2017

stevengj Jun 22, 2017

stevengj Jun 22, 2017

tkelman Jun 22, 2017

rofinn Jun 22, 2017

stevengj Jun 22, 2017

stevengj Jun 22, 2017

stevengj Jun 22, 2017

stevengj Jun 22, 2017

rofinn commented Jun 25, 2017

rofinn commented Jun 30, 2017

tkelman Jul 5, 2017

rofinn Jul 5, 2017

tkelman Jul 5, 2017

tkelman Jul 5, 2017

rofinn Jul 5, 2017

tkelman Jul 5, 2017

rofinn Jul 5, 2017

ararslan commented Jul 15, 2017

tkelman commented Jul 16, 2017

rofinn commented Jul 17, 2017

tkelman commented Jul 17, 2017

tkelman Jul 18, 2017

tkelman Jul 18, 2017

rofinn Jul 18, 2017 •

edited

Loading

tkelman commented Jul 18, 2017

ararslan commented Jul 18, 2017

		@@ -119,8 +94,6 @@ Currently, the `@compat` macro supports the following syntaxes:

		* `foreach`, similar to `map` but when the return value is not needed ([#13744])

		@@ -81,31 +73,12 @@ Currently, the `@compat` macro supports the following syntaxes:

		* `@compat Base.IndexStyle(::Type{<:MyArray}) = IndexLinear()` and `@compat Base.IndexStyle(::Type{<:MyArray}) = IndexCartesian()` to define traits for abstract arrays, replacing the former `Base.linearindexing{T<:MyArray}(::Type{T}) = Base.LinearFast()` and `Base.linearindexing{T<:MyArray}(::Type{T}) = Base.LinearSlow()`, respectively.

		* `Compat.collect(A)` returns an `Array`, no matter what indices the array `A` has (Julia 0.5 and higher). [#21257]

		@@ -690,79 +256,10 @@ end

		export @functorize
		macro functorize(f)

Dropping 0.4 #372

Dropping 0.4 #372

Conversation

rofinn commented Jun 21, 2017 • edited by ararslan Loading

stevengj commented Jun 21, 2017

stevengj Jun 22, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rofinn commented Jun 25, 2017

rofinn commented Jun 30, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ararslan commented Jul 15, 2017

tkelman commented Jul 16, 2017

rofinn commented Jul 17, 2017

tkelman commented Jul 17, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rofinn Jul 18, 2017 • edited Loading

Choose a reason for hiding this comment

tkelman commented Jul 18, 2017

ararslan commented Jul 18, 2017

rofinn commented Jun 21, 2017 •

edited by ararslan

Loading

stevengj Jun 22, 2017 •

edited

Loading

rofinn Jul 18, 2017 •

edited

Loading