Skip to content

Commit

Permalink
Drop compat code for atan from #574
Browse files Browse the repository at this point in the history
  • Loading branch information
martinholters committed Oct 8, 2019
1 parent eaaf649 commit 517beb9
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 13 deletions.
2 changes: 0 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,6 @@ Currently, the `@compat` macro supports the following syntaxes:
* `Compat.split` and `Compat.rsplit` accept `keepempty` keyword argument
if `splitter` is given as second argument ([#26634])

* `atan2` is now a 2-argument method of `atan` ([#27253]).

* `realmin` and `realmax` are now `floatmin` and `floatmax` ([#28302])

* `squeeze` is now `dropdims` ([#28303], [#26660]).
Expand Down
5 changes: 0 additions & 5 deletions src/Compat.jl
Original file line number Diff line number Diff line change
Expand Up @@ -82,11 +82,6 @@ end
end
end

# https://github.com/JuliaLang/julia/pull/27253
@static if VERSION < v"0.7.0-alpha.44"
Base.atan(x::Real, y::Real) = atan2(x, y)
end

# https://github.com/JuliaLang/julia/pull/26647
@static if VERSION < v"0.7.0-DEV.4724"
rsplit(s::AbstractString, splitter; limit::Integer=0, keepempty::Bool=false) =
Expand Down
6 changes: 6 additions & 0 deletions test/old.jl
Original file line number Diff line number Diff line change
Expand Up @@ -1219,3 +1219,9 @@ end
# julia#24839
@test permutedims([1 2; 3 4]) == [1 3; 2 4]
@test permutedims([1,2,3]) == [1 2 3]

# 0.7.0-alpha.44
@test atan(1, 2) == atan(0.5)
@test atan(1.0, 2.0) == atan(0.5)
@test atan(-1.0, -2.0) atan(0.5) - π
@test atan(big"-1.0", big"-2.0") atan(big"0.5") - π
6 changes: 0 additions & 6 deletions test/runtests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -80,12 +80,6 @@ let A = [1]
@test x == 1
end

# 0.7.0-alpha.44
@test atan(1, 2) == atan(0.5)
@test atan(1.0, 2.0) == atan(0.5)
@test atan(-1.0, -2.0) atan(0.5) - π
@test atan(big"-1.0", big"-2.0") atan(big"0.5") - π

# 0.7.0-DEV.4724
let
@test Compat.split("", ',' ; keepempty=false) == []
Expand Down

0 comments on commit 517beb9

Please sign in to comment.