Skip to content

Commit eaaf649

Browse files
committed
Drop compat code for permutedims from #582
1 parent 7cea1cf commit eaaf649

File tree

4 files changed

+4
-11
lines changed

4 files changed

+4
-11
lines changed

README.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,8 +66,6 @@ Currently, the `@compat` macro supports the following syntaxes:
6666

6767
* `range` supporting `stop` as positional argument ([#28708]).
6868

69-
* Single-argument `permutedims(x)` for matrices and vectors ([#24839]).
70-
7169
* `mapslices` with `dims` keyword argument ([#27828]).
7270

7371
* `hasproperty` and `hasfield` ([#28850]).

src/Compat.jl

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -82,11 +82,6 @@ end
8282
end
8383
end
8484

85-
if VERSION < v"0.7.0-DEV.2956" # julia#24839
86-
Base.permutedims(A::AbstractMatrix) = permutedims(A, (2,1))
87-
Base.permutedims(v::AbstractVector) = reshape(v, (1, length(v)))
88-
end
89-
9085
# https://github.com/JuliaLang/julia/pull/27253
9186
@static if VERSION < v"0.7.0-alpha.44"
9287
Base.atan(x::Real, y::Real) = atan2(x, y)

test/old.jl

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1215,3 +1215,7 @@ end
12151215
@test something(Some(2)) === 2
12161216
@test something(Some(2), 1) === 2
12171217
@test something(nothing, Some(1)) === 1
1218+
1219+
# julia#24839
1220+
@test permutedims([1 2; 3 4]) == [1 3; 2 4]
1221+
@test permutedims([1,2,3]) == [1 2 3]

test/runtests.jl

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -80,10 +80,6 @@ let A = [1]
8080
@test x == 1
8181
end
8282

83-
# julia#24839
84-
@test permutedims([1 2; 3 4]) == [1 3; 2 4]
85-
@test permutedims([1,2,3]) == [1 2 3]
86-
8783
# 0.7.0-alpha.44
8884
@test atan(1, 2) == atan(0.5)
8985
@test atan(1.0, 2.0) == atan(0.5)

0 commit comments

Comments
 (0)