-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Demo-Spatial Transformations #167
Merged
johnnychen94
merged 6 commits into
JuliaImages:source
from
ashwanirathee:Demo-SpatialTransformations
Dec 5, 2020
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
9394648
Demo-Spatial Transformations
ashwanirathee f248913
spelling mistake
ashwanirathee cb3ff3c
suggestions incorporated,except one
ashwanirathee 1d0838b
Used @view and PaddedView
ashwanirathee 93cb002
Removing error
ashwanirathee 51bd6e7
Suggested changes
ashwanirathee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
suggestions incorporated,except one
15 minor changes
- Loading branch information
commit cb3ff3cc14a0c9bd0d3d78682f574fe30955907e
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I believe it is a "misuse" of PaddedViews.
Originally,
PaddedViews
is designed to automatically pad the borders with the given value.I interpret it as a "misuse" because the output axes can be smaller than the original axes:
This is allowed, because sometimes we want to crop along one dimension, while padding along the other dimension, e.g.,
Quoted "misuse" because it totally depends on how users want from this.
Instead of referring to the "Alpha-Compositing" example, I guess we can add another example here for size-preserved cropping, i.e., filling the border with white pixels, or transparent pixels:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another thing I'd like to see here is the view version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am playing around with padded view for image pyramids demo,I'll add a example of this here in a day or two.