-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Demo-Spatial Transformations #167
Demo-Spatial Transformations #167
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even though these are basic operations, it is a very nice explanation and I'm impressed!
I've left tons of format and language suggestions, hope you don't mind.
Two other things I also wish to see in this demo are:
- image rotation:
imrotate
- image flip:
reverse
. Note that there are two flip options: flip the image data or flip the image axes.
15 minor changes
Can I make another demo for other transformations?? This has three operations which seems just the right amount for one demo I think. |
Of course. And feel free to resolve the comments I added. |
Is this PR done? ( I guess you're still playing with PaddedViews things?) |
I think so,I will change the image simple view to |
Can you explain this more? I'm not sure if I understand your question clearly. You don't need to convert a PaddedView array to image, because in JuliaImages, every colorant array is a valid image, i.e., |
# This demonstration shows how to use cropping,resizing and rescaling operations on an | ||
# image in Julia using ImageTransformations.jl | ||
|
||
using ImageCore, ImageShow, ImageTransformations, TestImages, OffsetArrays, ImageShow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The duplicated ImageShow
here.
Might be more concise to just import Images
if we have a lot of packages to import
using ImageCore, ImageShow, ImageTransformations, TestImages, OffsetArrays, ImageShow | |
using Images, TestImages, OffsetArrays |
Welcome as a contributor to JuliaImages! @ashwani-rathee |
:) |
Demo for cropping,resizing and rescaling has been added with this and address issue #130
closes #130