chore: lazily load large dependencies #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces the package loading time from 4.1s to 0.8s on my machine without affecting the execution time much. For 512x512 image: assess_psnr: before: 61.394 μs (0 allocations: 0 bytes) after: 62.824 μs (12 allocations: 352 bytes) assess_ssim: before: 9.029 ms (812 allocations: 41.13 MiB) after: 8.944 ms (869 allocations: 41.13 MiB)
Codecov Report
@@ Coverage Diff @@
## master #49 +/- ##
==========================================
- Coverage 97.23% 96.75% -0.49%
==========================================
Files 6 7 +1
Lines 181 185 +4
==========================================
+ Hits 176 179 +3
- Misses 5 6 +1
Continue to review full report at Codecov.
|
and only test x64 on ubuntu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the package loading time from 4.1s to 0.8s on my machine
without affecting the execution time much. For 512x512 image:
assess_psnr:before: 61.394 μs (0 allocations: 0 bytes)
after: 62.824 μs (12 allocations: 352 bytes)
assess_ssim:before: 9.029 ms (812 allocations: 41.13 MiB)
after: 8.944 ms (869 allocations: 41.13 MiB)