Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore SSIM_KERNEL and SSIM_W #51

Merged
merged 3 commits into from
Jul 5, 2022

Conversation

Octogonapus
Copy link
Contributor

This PR restores two globals, SSIM_KERNEL and SSIM_W, which were removed in v0.3.1.

Fixes #50.

@codecov
Copy link

codecov bot commented Jul 5, 2022

Codecov Report

Merging #51 (6b61385) into master (83e91c5) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
- Coverage   96.75%   96.68%   -0.08%     
==========================================
  Files           7        7              
  Lines         185      181       -4     
==========================================
- Hits          179      175       -4     
  Misses          6        6              
Impacted Files Coverage Δ
src/msssim.jl 100.00% <100.00%> (ø)
src/ssim.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83e91c5...6b61385. Read the comment docs.

Copy link
Member

@johnnychen94 johnnychen94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry! I didn't expect people to use this internal constant so changed this without notification.

Can you also help revert the constructor of MSSIM? Thanks

src/ssim.jl Outdated Show resolved Hide resolved
Copy link
Member

@johnnychen94 johnnychen94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix! I'll tag a release once the CI is green

@johnnychen94 johnnychen94 merged commit 13c73c3 into JuliaImages:master Jul 5, 2022
@Octogonapus Octogonapus deleted the restore_ssim_kernel branch July 5, 2022 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSIM_KERNEL was removed in the latest patch release
2 participants