Update Parsers support #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the Parsers compat versions to `"1, 2"`. As of v1.0.5, `Parsers.tryparse` ensured the full input buffer was consumed when parsing a value (as mentioned desirable in the now-deleted comment in `float_from_bytes`). So dropping support for older Parsers versions allows us to trust `Parsers.tryparse`, and those pre-1.0 versions are pretty old at this point anyway. I locally ran the JSON.jl tests under both Parsers v2.0.1 and v1.1.1 and ensured both were passing, so it shouldn't matter which version of Parsers ends up getting installed if there are other packages which don't 2.0 yet.
CI seems to fail so perhaps there is some difference between your local state and CI? |
|
Ah, I see JuliaData/Parsers.jl#85 now. |
|
Yeah, it looks like |
Codecov Report
@@ Coverage Diff @@
## master #327 +/- ##
==========================================
- Coverage 99.53% 99.51% -0.03%
==========================================
Files 7 5 -2
Lines 428 410 -18
==========================================
- Hits 426 408 -18
Misses 2 2
Continue to review full report at Codecov.
|
|
Ok, this looks good now. |
KristofferC
approved these changes
Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the Parsers compat versions to
"1, 2". As of v1.0.5,Parsers.tryparseensured the full input buffer was consumed whenparsing a value (as mentioned desirable in the now-deleted comment in
float_from_bytes). So dropping support for older Parsers versionsallows us to trust
Parsers.tryparse, and those pre-1.0 versions arepretty old at this point anyway.
I locally ran the JSON.jl tests under both Parsers v2.0.1 and v1.1.1 and
ensured both were passing, so it shouldn't matter which version of
Parsers ends up getting installed if there are other packages which
don't 2.0 yet.