Fix case when float parsing, we failed to check eof before peeking #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Discovered while porting JSON.jl to Parsers 2.0. Unfortunately, the byte peeking was under an `@inbounds`, so this usually wouldn't error unless julia was run with `--check-bounds=yes` (which is the default when running tests thankfully). Good candidate to backport for another 1.X release.
Codecov Report
@@ Coverage Diff @@
## main #85 +/- ##
==========================================
- Coverage 87.68% 87.65% -0.03%
==========================================
Files 9 9
Lines 2151 2154 +3
==========================================
+ Hits 1886 1888 +2
- Misses 265 266 +1
Continue to review full report at Codecov.
|
quinnj
added a commit
that referenced
this pull request
Jul 30, 2021
Discovered while porting JSON.jl to Parsers 2.0. Unfortunately, the byte peeking was under an `@inbounds`, so this usually wouldn't error unless julia was run with `--check-bounds=yes` (which is the default when running tests thankfully). Good candidate to backport for another 1.X release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered while porting JSON.jl to Parsers 2.0. Unfortunately, the byte
peeking was under an
@inbounds, so this usually wouldn't error unlessjulia was run with
--check-bounds=yes(which is the default whenrunning tests thankfully). Good candidate to backport for another 1.X
release.