Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Fix incorrect method leading to silent exceptions in signal handlers #595

Merged
merged 4 commits into from
Nov 16, 2021
Merged

Fix incorrect method leading to silent exceptions in signal handlers #595

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f1c45c7
fix warn
BioTurboNick Nov 16, 2021
2e5abdd
Better macro syntax
BioTurboNick Nov 16, 2021
ee182c7
Better macro syntax
BioTurboNick Nov 16, 2021
93e42de
This is probably what was meant
BioTurboNick Nov 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/GLib/signals.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ function GClosureMarshal(closuref::Ptr{Nothing}, return_value::Ptr{GValue}, n_pa
end

function blame(@nospecialize(cb))
warn("Executing ", cb, ":")
@warn "Executing $cb:"
end

# Signals API for the cb pointer
Expand Down
6 changes: 3 additions & 3 deletions src/text.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ function get_gtk_property(text::TI, key::Symbol, outtype::Type = Any)
elseif key === :pixbuf
convert(GdkPixbuf, ccall((:gtk_text_iter_get_char, libgtk), Ptr{GdkPixbuf}, (Ptr{GtkTextIter},), text))
else
warn("GtkTextIter doesn't have attribute with key $key")
@warn "GtkTextIter doesn't have attribute with key $key"
false
end)::outtype
end
Expand All @@ -207,7 +207,7 @@ function set_gtk_property!(text::Mutable{GtkTextIter}, key::Symbol, value)
elseif key === :visible_line_offset
ccall((:gtk_text_iter_set_visible_line_offset, libgtk), Cint, (Ptr{GtkTextIter}, Cint), text, value)
else
warn("GtkTextIter doesn't have attribute with key $key")
@warn "GtkTextIter doesn't have attribute with key $key"
false
end
return text
Expand Down Expand Up @@ -342,7 +342,7 @@ function Base.skip(iter::Mutable{GtkTextIter}, count::Integer, what::Symbol)
# ccall((:gtk_text_iter_set_offset, libgtk), Nothing, (Ptr{Nothing}, Cint), iter, 0)
# true
else
warn("GtkTextIter doesn't have iterator of type $what")
@warn "GtkTextIter doesn't have iterator of type $what"
false
end::Bool
end
Expand Down