Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Fix incorrect method leading to silent exceptions in signal handlers #595

Merged
merged 4 commits into from
Nov 16, 2021

Conversation

BioTurboNick
Copy link
Contributor

@BioTurboNick BioTurboNick commented Nov 16, 2021

Resolves #593

@codecov
Copy link

codecov bot commented Nov 16, 2021

Codecov Report

Merging #595 (93e42de) into master (0ff7447) will increase coverage by 0.50%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #595      +/-   ##
==========================================
+ Coverage   48.10%   48.60%   +0.50%     
==========================================
  Files          32       32              
  Lines        2580     2660      +80     
==========================================
+ Hits         1241     1293      +52     
- Misses       1339     1367      +28     
Impacted Files Coverage Δ
src/GLib/signals.jl 75.72% <0.00%> (-0.23%) ⬇️
src/text.jl 39.44% <0.00%> (-0.19%) ⬇️
src/Gtk.jl 85.18% <0.00%> (-3.28%) ⬇️
src/events.jl 43.87% <0.00%> (-2.36%) ⬇️
src/container.jl 46.51% <0.00%> (-0.99%) ⬇️
src/windows.jl 22.22% <0.00%> (-0.73%) ⬇️
src/displays.jl 13.04% <0.00%> (-0.44%) ⬇️
src/precompile.jl 0.00% <0.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ff7447...93e42de. Read the comment docs.

@tknopp tknopp merged commit c4e5578 into JuliaGraphics:master Nov 16, 2021
@tknopp
Copy link
Collaborator

tknopp commented Nov 16, 2021

thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exceptions being swallowed in signal handlers
2 participants