Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce setexcludinghandlers! #97

Merged

Conversation

rasmushenningsson
Copy link
Contributor

setexcludinghandlers! was removed in https://github.com/JuliaGizmos/Observables.jl/pull/84/files#diff-717dd66a485f4523942145feb17dfcebc7bf9e137ee03fa29c1ef8c8c3b1cad6L272 but it's unclear how to update code that uses setexcludinghandlers!.

This pull request just puts the old code back, since e.g. WebIO still relies on setexcludinghandlers!.

@rasmushenningsson
Copy link
Contributor Author

If there's a recommended way to do this in downstream packages, I can open a PR in WebIO instead. 🙂

@rasmushenningsson
Copy link
Contributor Author

Bump. 🙂
This is causing downstream issues for users of PlotlyJS.jl: JuliaPlots/PlotlyJS.jl#440

@rasmushenningsson
Copy link
Contributor Author

Bump 🙂

@SimonDanisch
Copy link
Member

SimonDanisch commented Sep 30, 2022

Sorry, always looked at this, weren't exactly sure if that's the right fix and then forgot about it.
I searched through the last versions and couldn't find setexcludinghandlers!.
Did you mean to bring this function back:

function setexcludinghandlers(observable::AbstractObservable, val, pred=x->true)
    setindex!(observable, val; notify=pred)
end

Or did I not search far enough?

@SimonDanisch
Copy link
Member

Oh nevermind, I got confused by the missing version tags and skipped 0.4 in the search, since I thought that was the most recent release :(
I guess that's the right fix then ;)

@SimonDanisch SimonDanisch merged commit 830ddaf into JuliaGizmos:master Sep 30, 2022
@rasmushenningsson
Copy link
Contributor Author

Thanks!

rasmushenningsson added a commit to rasmushenningsson/PlotlyJS.jl that referenced this pull request Sep 30, 2022
With the fix in JuliaGizmos/Observables.jl#97 reintroducing `setexcludinghandlers!`, the upper bound on WebIO is no longer need.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants