-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setexcludinghandlers! was removed in Observables 0.5 #493
Comments
Is there some fix? PlotlyJS is practically unusable because of this error. |
@PetrKryslUCSD I pin |
Excellent, that worked! Thanks! |
bump 🙂 |
Open to PRs here. Looks like this was a breaking change introduced to Observables.jl in https://github.com/JuliaGizmos/Observables.jl/pull/84/files#diff-717dd66a485f4523942145feb17dfcebc7bf9e137ee03fa29c1ef8c8c3b1cad6L272 (cc @SimonDanisch) |
I opened a PR in Observables (JuliaGizmos/Observables.jl#97) to reintroduce the function instead. |
@rasmushenningsson Why you don't do that. If you have a fix it could be a good point. I can't understand why PlotlyJS event handling is stuck because of this issue. That"s weird in the excellent Julia ecosystem. |
The PR in Observables was just merged, so no need for any action here. |
With the compat update to support Observables 0.5, we get problems here
WebIO.jl/src/scope.jl
Line 352 in c818b1f
since
setexcludinghandlers!
no longer exists.I'm not sure what a proper fix is.
The easiest fix would probably be to just access the field directly, since the function was implemented like this in Observables.jl:
setexcludinghandlers!(obs::AbstractObservable, val) = observe(obs).val = val
The text was updated successfully, but these errors were encountered: