Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setexcludinghandlers! was removed in Observables 0.5 #493

Closed
rasmushenningsson opened this issue Jun 14, 2022 · 8 comments
Closed

setexcludinghandlers! was removed in Observables 0.5 #493

rasmushenningsson opened this issue Jun 14, 2022 · 8 comments

Comments

@rasmushenningsson
Copy link
Contributor

rasmushenningsson commented Jun 14, 2022

With the compat update to support Observables 0.5, we get problems here

Observables.setexcludinghandlers!(ob, val)

since setexcludinghandlers! no longer exists.
I'm not sure what a proper fix is.

The easiest fix would probably be to just access the field directly, since the function was implemented like this in Observables.jl:
setexcludinghandlers!(obs::AbstractObservable, val) = observe(obs).val = val

@PetrKryslUCSD
Copy link

Is there some fix? PlotlyJS is practically unusable because of this error.

@mzaffalon
Copy link

mzaffalon commented Jul 6, 2022

@PetrKryslUCSD I pin WebIO to v0.8.17 as a temporarily workaround:
using Pkg; Pkg.add("WebIO"); Pkg.pin(name="WebIO", version="0.8.17").

@PetrKryslUCSD
Copy link

Excellent, that worked! Thanks!

@rasmushenningsson
Copy link
Contributor Author

bump 🙂

@twavv
Copy link
Member

twavv commented Aug 19, 2022

Open to PRs here. Looks like this was a breaking change introduced to Observables.jl in https://github.com/JuliaGizmos/Observables.jl/pull/84/files#diff-717dd66a485f4523942145feb17dfcebc7bf9e137ee03fa29c1ef8c8c3b1cad6L272 (cc @SimonDanisch)

@rasmushenningsson
Copy link
Contributor Author

I opened a PR in Observables (JuliaGizmos/Observables.jl#97) to reintroduce the function instead.
If they don't want to reintroduce it, I'll open a PR with a local fix here.

@rcqls
Copy link

rcqls commented Sep 30, 2022

I opened a PR in Observables (JuliaGizmos/Observables.jl#97) to reintroduce the function instead. If they don't want to reintroduce it, I'll open a PR with a local fix here.

@rasmushenningsson Why you don't do that. If you have a fix it could be a good point. I can't understand why PlotlyJS event handling is stuck because of this issue. That"s weird in the excellent Julia ecosystem.

@rasmushenningsson
Copy link
Contributor Author

The PR in Observables was just merged, so no need for any action here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants