-
Notifications
You must be signed in to change notification settings - Fork 19
Implement crstrait.
#140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement crstrait.
#140
Changes from all commits
82a2893
39b05cf
bd91c16
1daaffd
3fe4091
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -93,6 +93,26 @@ abstract type AbstractFeatureCollectionTrait <: AbstractTrait end | |
| "A FeatureCollectionTrait holds objects of `FeatureTrait`" | ||
| struct FeatureCollectionTrait <: AbstractFeatureCollectionTrait end | ||
|
|
||
| "Supertype for all coordinate reference system traits" | ||
| abstract type AbstractCRSTrait end | ||
|
|
||
| "An AbstractProjectedTrait for all projected coordinate reference systems" | ||
| abstract type AbstractProjectedTrait <: AbstractCRSTrait end | ||
| "An AbstractGeographicTrait for all geographic coordinate reference systems" | ||
| abstract type AbstractGeographicTrait <: AbstractCRSTrait end | ||
|
|
||
| "An ProjectedTrait for all projected coordinate reference systems" | ||
rafaqz marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| struct ProjectedTrait <: AbstractProjectedTrait end | ||
| "An GeographicTrait for all geographic coordinate reference systems" | ||
| struct GeographicTrait <: AbstractGeographicTrait end | ||
| "An UnknownTrait for all unknown (assumed projected) coordinate reference systems" | ||
| struct UnknownTrait <: AbstractProjectedTrait | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should this inherit from AbstractCRStrait? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If we assume projected anyway then dispatch can just be on There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, I assume you implement GeometryOps with Abstractprojected and catch both. |
||
| function UnknownTrait() | ||
| Base.depwarn("It is unknown whether your geometry is projected or geographic. Please implement `crstrait` for your geometry.", :UnknownTrait) | ||
| new() | ||
| end | ||
| end | ||
|
|
||
| "An AbstractRasterTrait for all rasters" | ||
| abstract type AbstractRasterTrait <: AbstractTrait end | ||
| struct RasterTrait <: AbstractRasterTrait end | ||
Uh oh!
There was an error while loading. Please reload this page.