Skip to content

Conversation

@evetion
Copy link
Member

@evetion evetion commented Jul 4, 2024

To distinguish between geographic and projected coordinate systems. Fixes #119.

@evetion evetion requested review from asinghvi17, rafaqz and visr July 4, 2024 21:55
@asinghvi17
Copy link
Member

I think we would also want similar traits in GFT or some kind of trait wrapper, so that users can choose to have CRS traits evaluated at compile time too! It should be possible to detect this using Proj I think.

@evetion
Copy link
Member Author

evetion commented Jul 5, 2024

I think we would also want similar traits in GFT or some kind of trait wrapper, so that users can choose to have CRS traits evaluated at compile time too! It should be possible to detect this using Proj I think.

Agreed, this is would be the setup for that. For now, the default UnknownTrait() should be compiled away.

"An ProjectedTrait for all projected coordinate reference systems"
struct ProjectedTrait <: AbstractProjectedTrait end
"An UnknownTrait for all unknown (assumed projected) coordinate reference systems"
struct UnknownTrait <: AbstractProjectedTrait
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this inherit from AbstractCRStrait?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we assume projected anyway then dispatch can just be on AbstractProjectedTrait right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I assume you implement GeometryOps with Abstractprojected and catch both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Add CRS traits

4 participants