Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using deprecated signatures from Distances.jl #529

Merged
merged 4 commits into from
Oct 11, 2023
Merged

Stop using deprecated signatures from Distances.jl #529

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4d237b6
Stop using deprecated signatures from Distances.jl
simsurace Oct 6, 2023
5e089e7
Delete file that is not needed
simsurace Oct 6, 2023
624f7ad
Bump version and compat
simsurace Oct 6, 2023
043bab8
Change signature of `KernelFunctions.pairwise!`
simsurace Oct 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/distances/pairwise.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,13 @@
end

function pairwise!(out::AbstractMatrix, d::PreMetric, x::AbstractVector{<:Real})
return Distances.pairwise!(out, d, reshape(x, :, 1); dims=1)
return Distances.pairwise!(d, out, reshape(x, :, 1); dims=1)

Check warning on line 24 in src/distances/pairwise.jl

View check run for this annotation

Codecov / codecov/patch

src/distances/pairwise.jl#L24 

Added line #L24 was not covered by tests
end

function pairwise!(
out::AbstractMatrix, d::PreMetric, x::AbstractVector{<:Real}, y::AbstractVector{<:Real}
)
return Distances.pairwise!(out, d, reshape(x, :, 1), reshape(y, :, 1); dims=1)
return Distances.pairwise!(d, out, reshape(x, :, 1), reshape(y, :, 1); dims=1)

Check warning on line 30 in src/distances/pairwise.jl

View check run for this annotation

Codecov / codecov/patch

src/distances/pairwise.jl#L30 

Added line #L30 was not covered by tests
end

# Also defines the colwise method for abstractvectors
Expand Down
8 changes: 4 additions & 4 deletions src/utils.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,10 +108,10 @@
return Distances_pairwise(d, x.X, reduce(hcat, y); dims=2)
end
function pairwise!(out::AbstractMatrix, d::PreMetric, x::ColVecs)
return Distances.pairwise!(out, d, x.X; dims=2)
return Distances.pairwise!(d, out, x.X; dims=2)

Check warning on line 111 in src/utils.jl

View check run for this annotation

Codecov / codecov/patch

src/utils.jl#L111 

Added line #L111 was not covered by tests
end
function pairwise!(out::AbstractMatrix, d::PreMetric, x::ColVecs, y::ColVecs)
return Distances.pairwise!(out, d, x.X, y.X; dims=2)
return Distances.pairwise!(d, out, x.X, y.X; dims=2)

Check warning on line 114 in src/utils.jl

View check run for this annotation

Codecov / codecov/patch

src/utils.jl#L114 

Added line #L114 was not covered by tests
end

"""
Expand Down Expand Up @@ -179,10 +179,10 @@
return Distances_pairwise(d, x.X, permutedims(reduce(hcat, y)); dims=1)
end
function pairwise!(out::AbstractMatrix, d::PreMetric, x::RowVecs)
return Distances.pairwise!(out, d, x.X; dims=1)
return Distances.pairwise!(d, out, x.X; dims=1)

Check warning on line 182 in src/utils.jl

View check run for this annotation

Codecov / codecov/patch

src/utils.jl#L182 

Added line #L182 was not covered by tests
end
function pairwise!(out::AbstractMatrix, d::PreMetric, x::RowVecs, y::RowVecs)
return Distances.pairwise!(out, d, x.X, y.X; dims=1)
return Distances.pairwise!(d, out, x.X, y.X; dims=1)

Check warning on line 185 in src/utils.jl

View check run for this annotation

Codecov / codecov/patch

src/utils.jl#L185 

Added line #L185 was not covered by tests
end

# Resolve ambiguity error for ColVecs vs RowVecs. #346
Expand Down
Loading