-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop using deprecated signatures from Distances.jl #529
Conversation
Codecov ReportAttention:
📢 Thoughts on this report? Let us know!. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to fix those! Two main comments:
- The deprecations and in particular the new syntax was only added in Change signature of
pairwise!
andcolwise!
JuliaStats/Distances.jl#239, so we have to bump the Distances compat entry to 0.10.9. - We should change the function signature of
KernelFunctions.pairwise!
in the same way.
Thanks for catching this. If you could please bump the patch version, I'm happy to approve |
Bump :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
We are using a deprecated signature of
Distances.pairwise!
, leading to distracting warnings.This PR fixes those.