Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using deprecated signatures from Distances.jl #529

Merged
merged 4 commits into from
Oct 11, 2023

Conversation

simsurace
Copy link
Member

We are using a deprecated signature of Distances.pairwise!, leading to distracting warnings.
This PR fixes those.

@simsurace simsurace mentioned this pull request Oct 6, 2023
5 tasks
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/distances/pairwise.jl 75.00% <100.00%> (ø)
src/matrix/kernelmatrix.jl 95.91% <100.00%> (ø)
src/utils.jl 88.09% <100.00%> (ø)
src/basekernels/fbm.jl 26.66% <0.00%> (ø)

📢 Thoughts on this report? Let us know!.

Copy link
Member

@devmotion devmotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to fix those! Two main comments:

@willtebbutt
Copy link
Member

Thanks for catching this. If you could please bump the patch version, I'm happy to approve

@simsurace
Copy link
Member Author

Bump :)

Copy link
Member

@devmotion devmotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@simsurace simsurace merged commit 095b8d0 into master Oct 11, 2023
16 of 22 checks passed
@simsurace simsurace deleted the fix-depr-warn-distances branch October 11, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants